Skip to content

Conversation

@brad-decker
Copy link
Contributor

Explanation

We are getting gasEstimateType by examining which button of the old gas buttons UI was selected. We only used this value for a legacy metric event for transactions we no longer use.

More Information

Fixes #15415

@metamaskbot
Copy link
Collaborator

Builds ready [e9f8475]
Page Load Metrics (1658 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint83134104147
domContentLoaded1499188016309646
load14991883165811053
domInteractive1499188016309646

highlights:

storybook

@PeterYinusa PeterYinusa added this to the v10.18.2 milestone Aug 2, 2022
@brad-decker brad-decker marked this pull request as ready for review August 2, 2022 18:55
@brad-decker brad-decker requested a review from a team as a code owner August 2, 2022 18:55
@brad-decker brad-decker requested a review from Gtonizuka August 2, 2022 18:55
@PeterYinusa
Copy link
Contributor

LGTM!

@adonesky1 adonesky1 merged commit ddadc79 into develop Aug 2, 2022
@adonesky1 adonesky1 deleted the fix-15415 branch August 2, 2022 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: new BigNumber() not a number: [object Object]

6 participants