Skip to content

Conversation

@brad-decker
Copy link
Contributor

Explanation

There seems to be a case (report happened after user imported seed phrase) where an action can be dispatched but 'undefined' is the value for account. This adds a safety check to prevent attempting to set values from an erroneous payload.

@brad-decker brad-decker marked this pull request as ready for review August 3, 2022 17:08
@brad-decker brad-decker requested a review from a team as a code owner August 3, 2022 17:08
@brad-decker brad-decker requested a review from hmalik88 August 3, 2022 17:08
@PeterYinusa PeterYinusa added this to the v10.18.2 milestone Aug 3, 2022
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [4520c8a]
Page Load Metrics (1664 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89140108157
domContentLoaded1544185716597938
load1544187516648038
domInteractive1544185716597938

highlights:

storybook

@brad-decker brad-decker merged commit cfe5f3a into develop Aug 3, 2022
@brad-decker brad-decker deleted the fix-15402 branch August 3, 2022 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants