Skip to content

Fix optimism send flow #15419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

Fix optimism send flow #15419

merged 1 commit into from
Aug 2, 2022

Conversation

@danjm
Copy link
Contributor

@danjm danjm commented Aug 2, 2022

Fixes #15416

Introduced here

@danjm danjm requested a review from a team as a code owner August 2, 2022 15:37
@danjm danjm requested a review from garrettbear August 2, 2022 15:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm added this to the v10.18.2 milestone Aug 2, 2022
@danjm danjm self-assigned this Aug 2, 2022
digiwand
digiwand approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. will we be following this up with a test?

@metamaskbot
Copy link
Collaborator

metamaskbot commented Aug 2, 2022

Builds ready [28998d1]
Page Load Metrics (1605 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint80137100157
domContentLoaded14802148158813967
load14802163160513967
domInteractive14802148158813967

highlights:

storybook

@danjm danjm merged commit d484f10 into develop Aug 2, 2022
@danjm danjm deleted the fix-optimism branch August 2, 2022 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@garrettbear garrettbear Awaiting requested review from garrettbear garrettbear is a code owner automatically assigned from MetaMask/extension-devs

3 more reviewers

@brad-decker brad-decker brad-decker approved these changes

@ryanml ryanml ryanml approved these changes

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danjm danjm

Labels

None yet

Projects

None yet

Milestone

v10.18.2

Development

Successfully merging this pull request may close these issues.

Next button disabled on send flow on optimism network

6 participants

@danjm @metamaskbot @brad-decker @ryanml @digiwand