Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v2.18.0 #2761

Merged
merged 132 commits into from
Jan 1, 2022
Merged

release v2.18.0 #2761

merged 132 commits into from
Jan 1, 2022

Conversation

MichMich
Copy link
Collaborator

@MichMich MichMich commented Jan 1, 2022

Hello and thank you for wanting to contribute to the MagicMirror project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

fewieden and others added 30 commits September 18, 2021 03:50
…nd-nunjuck-templating

Clean up updatenotifications and nunjuck templating
MichMich and others added 28 commits December 23, 2021 18:56
@codecov-commenter
Copy link

Codecov Report

Merging #2761 (be073da) into master (222a5f3) will decrease coverage by 2.15%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
- Coverage   70.83%   68.67%   -2.16%     
==========================================
  Files          13        8       -5     
  Lines         696      265     -431     
==========================================
- Hits          493      182     -311     
+ Misses        203       83     -120     
Impacted Files Coverage Δ
js/electron.js 71.66% <50.00%> (-2.02%) ⬇️
js/app.js 59.66% <0.00%> (-10.09%) ⬇️
js/server.js 85.18% <0.00%> (-1.86%) ⬇️
modules/default/calendar/calendarfetcher.js
modules/default/calendar/calendarutils.js
js/class.js
js/node_helper.js
modules/default/calendar/node_helper.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222a5f3...be073da. Read the comment docs.

@MichMich MichMich merged commit a6cbc9f into master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.