Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare-release-2.18.0 #2760

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Prepare-release-2.18.0 #2760

merged 1 commit into from
Jan 1, 2022

Conversation

MichMich
Copy link
Collaborator

@MichMich MichMich commented Jan 1, 2022

Hello and thank you for wanting to contribute to the MagicMirror project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@codecov-commenter
Copy link

Codecov Report

Merging #2760 (4c919a7) into develop (7a7ed48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2760   +/-   ##
========================================
  Coverage    68.67%   68.67%           
========================================
  Files            8        8           
  Lines          265      265           
========================================
  Hits           182      182           
  Misses          83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7ed48...4c919a7. Read the comment docs.

@MichMich MichMich merged commit be073da into develop Jan 1, 2022
@MichMich MichMich deleted the prepare-release-2.18.0 branch January 1, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants