Broadcast custom symbols in CALENDAR_EVENTS #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2754 +/- ##
========================================
Coverage 68.67% 68.67%
========================================
Files 8 8
Lines 265 265
========================================
Hits 182 182
Misses 83 83 Continue to review full report at Codecov.
|
rejas
reviewed
Dec 26, 2021
| @@ -237,18 +237,6 @@ Module.register("calendar", { | |||
| symbolWrapper.className = "symbol align-right " + symbolClass; | |||
|
|
|||
| const symbols = this.symbolsForEvent(event); | |||
| // If symbols are displayed and custom symbol is set, replace event symbol | |||
| if (this.config.displaySymbol && this.config.customEvents.length > 0) { | |||
There was a problem hiding this comment.
This check isnt in the added code. Dont we need it there?
There was a problem hiding this comment.
I don't believe so, the check was redundant in the old location, it was already inside an if (this.config.displaySymbol), and the other call should have the custom symbol information even if symbols aren't being displayed, since it's populating the notification message
rejas
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for displaying event symbols to MMM-MonthlyCalendar, and received a bug report that custom symbols aren't being displayed. Move the custom event logic into symbolsForEvent so that they are properly set in the CALENDAR_EVENTS message.