Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move calendar tests from category electron to e2e #2683

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Oct 4, 2021

related to #2408

Calendar tests are now running without electron.

@codecov-commenter
Copy link

Codecov Report

Merging #2683 (1d12e57) into develop (e4a0a51) will decrease coverage by 1.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2683      +/-   ##
===========================================
- Coverage    70.83%   69.46%   -1.37%     
===========================================
  Files           13        8       -5     
  Lines          696      262     -434     
===========================================
- Hits           493      182     -311     
+ Misses         203       80     -123     
Impacted Files Coverage Δ
js/app.js 59.66% <0.00%> (-10.09%) ⬇️
modules/default/calendar/calendarfetcher.js
js/node_helper.js
modules/default/calendar/calendarutils.js
modules/default/calendar/node_helper.js
js/class.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a0a51...1d12e57. Read the comment docs.

@MichMich MichMich merged commit 016a1e9 into MagicMirrorOrg:develop Oct 5, 2021
@khassel khassel deleted the calendar-test branch October 5, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants