Weekly patch release v1.9.3 #16790

awaelchli · 2023-02-16T23:36:09Z

What does this PR do?

How to get your commit released:

Set the milestone on your PR to 1.9.x
git checkout 1-9-3-draft
git cherry-pick [your commit]
Resolve conflicts (warning - the package structure has severely diverged from master)
git push
Make sure that tests pass, so that the next person can cherry pick their changes

List all commits:

gh pr list -s merged -S 'merged:2023-02-14T19:30:00.000Z..2023-02-19T12:00:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == null) or (.milestone.title == "v1.9.x")) | [.url, .mergeCommit.oid, .title] | join(" ")' --limit 500

Previous Release (1.9.2): #16725

cc @Borda @carmocca @akihironitta @justusschock @awaelchli

update docker

github-actions · 2023-02-16T23:42:00Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, tests/tests_pytorch/accelerators/test_tpu.py, tests/tests_pytorch/deprecated_api/test_remove_2-0.py, tests/tests_pytorch/strategies/test_registry.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/properties/test_estimated_stepping_batches.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, tests/tests_pytorch/accelerators/test_tpu.py, tests/tests_pytorch/deprecated_api/test_remove_2-0.py, tests/tests_pytorch/strategies/test_registry.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/properties/test_estimated_stepping_batches.py, src/lightning_fabric/cli.py, src/lightning_fabric/connector.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, tests/tests_pytorch/accelerators/test_tpu.py, tests/tests_pytorch/deprecated_api/test_remove_2-0.py, tests/tests_pytorch/strategies/test_registry.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/properties/test_estimated_stepping_batches.py.

🔴 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	failure	❌

These checks are required after the changes to src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, tests/tests_pytorch/accelerators/test_tpu.py, tests/tests_pytorch/deprecated_api/test_remove_2-0.py, tests/tests_pytorch/strategies/test_registry.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/properties/test_estimated_stepping_batches.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py.

🟡 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.10, 11.3.1)	no_status	❓
build-cuda (3.9, 1.11, 11.3.1)	no_status	❓
build-cuda (3.9, 1.12, 11.6.1)	no_status	❓
build-cuda (3.9, 1.13, 11.7.1)	no_status	❓
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.10, 11.3.1)	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-xla (3.7, 1.12)	success	✅

These checks are required after the changes to dockers/base-cuda/Dockerfile.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, tests/tests_fabric/test_cli.py, tests/tests_fabric/test_connector.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, tests/tests_fabric/test_cli.py, tests/tests_fabric/test_connector.py.

🔴 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	failure	❌
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/core/flow.py, src/lightning_app/core/plugin.py, src/lightning_app/core/work.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/multiprocess.py, src/lightning_app/utilities/commands/base.py, src/lightning_app/utilities/load_app.py, src/lightning_app/utilities/network.py, tests/tests_app/cli/test_run_app.py, tests/tests_app/core/lightning_app/test_configure_layout.py, tests/tests_app/core/test_plugin.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/test_network.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/core/flow.py, src/lightning_app/core/plugin.py, src/lightning_app/core/work.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/multiprocess.py, src/lightning_app/utilities/commands/base.py, src/lightning_app/utilities/load_app.py, src/lightning_app/utilities/network.py, tests/integrations_app/apps/idle_timeout/app.py.

🔴 lightning_app: Azure

Check ID	Status
App.cloud-e2e	failure	❌

These checks are required after the changes to src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/core/flow.py, src/lightning_app/core/plugin.py, src/lightning_app/core/work.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/multiprocess.py, src/lightning_app/utilities/commands/base.py, src/lightning_app/utilities/load_app.py, src/lightning_app/utilities/network.py, tests/integrations_app/apps/idle_timeout/app.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/core/flow.py, src/lightning_app/core/plugin.py, src/lightning_app/core/work.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/multiprocess.py, src/lightning_app/utilities/commands/base.py, src/lightning_app/utilities/load_app.py, src/lightning_app/utilities/network.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/core/flow.py, src/lightning_app/core/plugin.py, src/lightning_app/core/work.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/multiprocess.py, src/lightning_app/utilities/commands/base.py, src/lightning_app/utilities/load_app.py, src/lightning_app/utilities/network.py, src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/version.info.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/core/flow.py, src/lightning_app/core/plugin.py, src/lightning_app/core/work.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/multiprocess.py, src/lightning_app/utilities/commands/base.py, src/lightning_app/utilities/load_app.py, src/lightning_app/utilities/network.py, src/lightning_fabric/cli.py, src/lightning_fabric/connector.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/version.info.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning_app/CHANGELOG.md, src/lightning_fabric/CHANGELOG.md, src/pytorch_lightning/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Co-authored-by: thomas chaton <thomas@grid.ai>

Fix

codecov · 2023-02-18T00:15:20Z

Codecov Report

Merging #16790 (f1d1d66) into release/stable (c5b836a) will increase coverage by 0%.
The diff coverage is 91%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release/stable   #16790    +/-   ##
================================================
  Coverage              82%      82%            
================================================
  Files                 474      452    -22     
  Lines               35130    34943   -187     
================================================
- Hits                28705    28657    -48     
+ Misses               6425     6286   -139

src/pytorch_lightning/CHANGELOG.md

* fix(app): URLs, create run on app run * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

tpu fixes

tchaton

LGTM !

Update colossalai version in Dockerfile (#16766)

20b890a

update docker

github-actions bot added the ci Continuous Integration label Feb 16, 2023

awaelchli added release app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package and removed ci Continuous Integration labels Feb 16, 2023

awaelchli added this to the v1.9.x milestone Feb 16, 2023

awaelchli mentioned this pull request Feb 16, 2023

Fix set_epoch not getting called for prediction dataloaders #16785

Merged

awaelchli marked this pull request as ready for review February 16, 2023 23:41

awaelchli requested review from Borda, carmocca and akihironitta as code owners February 16, 2023 23:41

awaelchli mentioned this pull request Feb 17, 2023

[App] Refactor plugins to be a standalone LightningPlugin #16765

Merged

8 tasks

ethanwharris and others added 2 commits February 17, 2023 09:37

[App] Fix idle timeout e2e (#16786)

2835cfd

[App] Reserve APP_SERVER_PORT in cloud port allocation (#16782)

e680e66

Co-authored-by: thomas chaton <thomas@grid.ai>

ethanwharris requested review from tchaton, lantiga, hhsecond and ethanwharris as code owners February 17, 2023 09:38

github-actions bot added ci Continuous Integration and removed pl Generic label for PyTorch Lightning package labels Feb 17, 2023

fix warning so the user has a clear next step (#16751)

3995574

carmocca requested review from justusschock and williamFalcon as code owners February 17, 2023 12:38

github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 17, 2023

carmocca force-pushed the 1-9-3-draft branch from 3302690 to 8a1607d Compare February 17, 2023 16:40

[App] Refactor plugins to be a standalone LightningPlugin (#16765)

595faa1

Fix

awaelchli force-pushed the 1-9-3-draft branch from 8a1607d to c42fc4b Compare February 17, 2023 23:54

github-actions bot added the fabric lightning.fabric.Fabric label Feb 20, 2023

awaelchli force-pushed the 1-9-3-draft branch from 95254f3 to 6657052 Compare February 20, 2023 13:22

awaelchli self-assigned this Feb 20, 2023

awaelchli force-pushed the 1-9-3-draft branch from 8531e7a to 07459ab Compare February 20, 2023 17:38

awaelchli changed the title ~~[WIP] Weekly patch release v1.9.3~~ Weekly patch release v1.9.3 Feb 21, 2023

awaelchli force-pushed the 1-9-3-draft branch 3 times, most recently from c6df9b8 to 07ee56a Compare February 21, 2023 14:57

carmocca approved these changes Feb 21, 2023

View reviewed changes

src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved

yurijmikhalevich and others added 5 commits February 21, 2023 18:38

Bump Lightning-AI/utilities from 0.4.1 to 0.6.0 (#16812)

8914f48

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fix XLAEnvironment detection on TPU pod (#16806)

bdaba90

tpu fixes

Set accelerator through CLI only if set explicitly (#16818)

31c307a

Release 1.9.3

f1d1d66

carmocca force-pushed the 1-9-3-draft branch from 07ee56a to f1d1d66 Compare February 21, 2023 18:06

Borda approved these changes Feb 21, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Feb 21, 2023

tchaton approved these changes Feb 21, 2023

View reviewed changes

ethanwharris approved these changes Feb 21, 2023

View reviewed changes

lexierule merged commit 1091484 into release/stable Feb 21, 2023

lexierule deleted the 1-9-3-draft branch February 21, 2023 20:10

awaelchli mentioned this pull request Feb 21, 2023

Update changelog after 1.9.3 and bump version for RC #16833

Merged

carmocca mentioned this pull request Feb 27, 2023

Weekly patch release v1.9.4 #16884

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly patch release v1.9.3 #16790

Weekly patch release v1.9.3 #16790

awaelchli commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

codecov bot commented Feb 18, 2023 •

edited

Loading

tchaton left a comment

Weekly patch release v1.9.3 #16790

Weekly patch release v1.9.3 #16790

Conversation

awaelchli commented Feb 16, 2023 • edited Loading

What does this PR do?

github-actions bot commented Feb 16, 2023 • edited Loading

⛈️ Required checks status: Has failure 🔴

Groups summary

codecov bot commented Feb 18, 2023 • edited Loading

Codecov Report

tchaton left a comment

Choose a reason for hiding this comment

awaelchli commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

codecov bot commented Feb 18, 2023 •

edited

Loading