Release 1.9.3

Lightning-AI · Feb 21, 2023 · 1091484 · 1091484
1 parent f588893
commit 1091484
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 33 deletions.
diff --git a/.github/workflows/ci-tests-pytorch.yml b/.github/workflows/ci-tests-pytorch.yml
@@ -142,22 +142,25 @@ jobs:
         # pip install -r requirements/pytorch/strategies.txt --find-links ${TORCH_URL}
         pip list
 
-    - name: Reinstall Horovod if necessary
-      if: runner.os != 'windows'
-      env:
-        HOROVOD_BUILD_ARCH_FLAGS: "-mfma"
-        HOROVOD_WITHOUT_MXNET: 1
-        HOROVOD_WITHOUT_TENSORFLOW: 1
-      run: |
-        HOROVOD_BUILT=$(python -c "import horovod.torch; horovod.torch.nccl_built(); print('SUCCESS')" || true)
-        if [[ $HOROVOD_BUILT != "SUCCESS" ]]; then
-          pip uninstall -y horovod
-          grep "horovod" requirements/pytorch/strategies.txt > requirements/pytorch/horovod.txt
-          pip install --no-cache-dir -r requirements/pytorch/horovod.txt
-        fi
-        horovodrun --check-build
-        python -c "import horovod.torch"
-        pip list
+#    - name: Reinstall Horovod if necessary
+#      if: runner.os != 'windows'
+#      env:
+#        HOROVOD_BUILD_ARCH_FLAGS: "-mfma"
+#        HOROVOD_WITHOUT_MXNET: 1
+#        HOROVOD_WITHOUT_TENSORFLOW: 1
+#      run: |
+#        HOROVOD_BUILT=$(python -c "import horovod.torch; horovod.torch.nccl_built(); print('SUCCESS')" || true)
+#        if [[ $HOROVOD_BUILT != "SUCCESS" ]]; then
+#          pip uninstall -y horovod
+#          # grep "horovod" requirements/pytorch/strategies.txt > requirements/pytorch/horovod.txt
+#          # pip install --no-cache-dir -r requirements/pytorch/horovod.txt
+#
+#          # we hardcode the version for testing due to difficulties installing and compiling the package
+#          pip install --no-cache-dir horovod==0.21.2
+#        fi
+#        horovodrun --check-build
+#        python -c "import horovod.torch"
+#        pip list
 
     - name: Cache datasets
       uses: actions/cache@v3

diff --git a/src/lightning_app/CHANGELOG.md b/src/lightning_app/CHANGELOG.md
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
+## [1.9.3] - 2023-02-21
+
+### Fixed
+
+- Fixed `lightning open` command and improved redirects ([#16794](https://github.com/Lightning-AI/lightning/pull/16794))
+
 
 ## [1.9.2] - 2023-02-15
 

diff --git a/src/lightning_fabric/CHANGELOG.md b/src/lightning_fabric/CHANGELOG.md
@@ -5,20 +5,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 
-## [1.9.3] - 2023-MM-DD
-
-### Added
-
-
-### Changed
-
-
-### Deprecated
-
--
-
-
-### Removed
+## [1.9.3] - 2023-02-21
 
 ### Fixed
 

diff --git a/src/pytorch_lightning/CHANGELOG.md b/src/pytorch_lightning/CHANGELOG.md
@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 
-## [1.9.3] - YYYY-MM-DD
+## [1.9.3] - 2023-02-21
 
 ### Fixed
 

diff --git a/src/version.info b/src/version.info
@@ -1 +1 @@
-1.9.2
+1.9.3
diff --git a/tests/tests_app/runners/test_cloud.py b/tests/tests_app/runners/test_cloud.py
@@ -2048,7 +2048,7 @@ def test_get_app_url(monkeypatch, project, run_instance, user, tab, lightning_cl
     runtime = CloudRuntime()
 
     with mock.patch(
-        "lightning.app.runners.cloud.get_lightning_cloud_url", mock.MagicMock(return_value=lightning_cloud_url)
+        "lightning_app.runners.cloud.get_lightning_cloud_url", mock.MagicMock(return_value=lightning_cloud_url)
     ):
         assert runtime._get_app_url(project, run_instance, tab) == expected_url