Weekly patch release v1.9.4 #16884

carmocca · 2023-02-27T16:13:18Z

What does this PR do?

Previous release: #16790

cc @Borda @carmocca @justusschock @awaelchli

) Co-authored-by: Ethan Harris <ethanwharris@gmail.com>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

github-actions · 2023-02-27T19:20:50Z

🌩️ Required checks status: Pending 🟡

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, tests/tests_pytorch/utilities/test_parsing.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, tests/tests_pytorch/utilities/test_parsing.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, tests/tests_pytorch/utilities/test_parsing.py.

🟡 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	queued	⌛

These checks are required after the changes to src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, tests/tests_pytorch/utilities/test_parsing.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, docs/source-pytorch/cli/lightning_cli_intermediate_2.rst.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, tests/tests_fabric/accelerators/test_cuda.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, tests/tests_fabric/accelerators/test_cuda.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning_app/__init__.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/plugin/__init__.py, src/lightning_app/plugin/actions.py, src/lightning_app/plugin/plugin.py, src/lightning_app/runners/cloud.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/cli_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/load_app.py, tests/tests_app/core/scripts/app_with_local_import.py, tests/tests_app/plugin/__init__.py, tests/tests_app/plugin/test_plugin.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/test_cli_helpers.py, tests/tests_app/utilities/test_load_app.py, requirements/app/base.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/__init__.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/plugin/__init__.py, src/lightning_app/plugin/actions.py, src/lightning_app/plugin/plugin.py, src/lightning_app/runners/cloud.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/cli_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/load_app.py, tests/integrations_app/public/test_commands_and_api.py, tests/integrations_app/public/test_v0_app.py, requirements/app/base.txt.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning_app/__init__.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/plugin/__init__.py, src/lightning_app/plugin/actions.py, src/lightning_app/plugin/plugin.py, src/lightning_app/runners/cloud.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/cli_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/load_app.py, requirements/app/base.txt, tests/integrations_app/public/test_commands_and_api.py, tests/integrations_app/public/test_v0_app.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/__init__.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/plugin/__init__.py, src/lightning_app/plugin/actions.py, src/lightning_app/plugin/plugin.py, src/lightning_app/runners/cloud.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/cli_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/load_app.py, docs/source-app/examples/file_server/app.py, requirements/app/base.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/app/base.txt, src/lightning_app/__init__.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/plugin/__init__.py, src/lightning_app/plugin/actions.py, src/lightning_app/plugin/plugin.py, src/lightning_app/runners/cloud.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/cli_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/load_app.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, src/version.info.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_app/__init__.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/plugin/__init__.py, src/lightning_app/plugin/actions.py, src/lightning_app/plugin/plugin.py, src/lightning_app/runners/cloud.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/cli_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/load_app.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/strategies/launchers/xla.py, src/lightning_fabric/strategies/xla.py, src/pytorch_lightning/strategies/launchers/xla.py, src/pytorch_lightning/strategies/tpu_spawn.py, src/pytorch_lightning/utilities/parsing.py, src/version.info, requirements/app/base.txt.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning_app/CHANGELOG.md, src/lightning_fabric/CHANGELOG.md, src/pytorch_lightning/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2023-02-27T19:28:38Z

Codecov Report

Merging #16884 (83b112e) into release/stable (1091484) will increase coverage by 0%.
The diff coverage is 40%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release/stable   #16884    +/-   ##
================================================
  Coverage              82%      82%            
================================================
  Files                 474      454    -20     
  Lines               35160    35042   -118     
================================================
+ Hits                28685    28713    +28     
+ Misses               6475     6329   -146

…6866) Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

carmocca and others added 5 commits February 27, 2023 17:00

Version and CHANGELOG preparation

c3a94ad

[App] Fix local app run with relative import (#16835)

4ac3917

Remove implicit frontend testing from testing.run_app_in_cloud (#16741

579555f

) Co-authored-by: Ethan Harris <ethanwharris@gmail.com>

Fix for hanging issue on TPU Pod (#16844)

b29b5da

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Fix imports for lightning cli examples (#16871)

70de140

carmocca added the release label Feb 27, 2023

carmocca added this to the v1.9.x milestone Feb 27, 2023

carmocca self-assigned this Feb 27, 2023

carmocca requested review from williamFalcon, lantiga, Borda, edenlightning, tchaton, awaelchli, hhsecond, ethanwharris, justusschock and akihironitta as code owners February 27, 2023 16:13

github-actions bot added app (removed) Generic label for Lightning App package ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Feb 27, 2023

mergify bot added the has conflicts label Feb 27, 2023

carmocca changed the base branch from master to release/stable February 27, 2023 16:14

mergify bot removed the has conflicts label Feb 27, 2023

carmocca mentioned this pull request Feb 27, 2023

[App] Add support for plugins to return actions #16832

Merged

7 tasks

Incorporate pytorch's fixes in device_count_nvml #16795

7699bad

github-actions bot removed the ci Continuous Integration label Feb 27, 2023

awaelchli force-pushed the 1.9.4-draft branch 2 times, most recently from 8b6917a to eee7fca Compare February 27, 2023 21:39

awaelchli and others added 2 commits February 28, 2023 02:48

Fix support for passing -1 to find_usable_cuda_devices function (#1…

24c79d3

…6866) Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Backwards compatibility for get_init_args (#16851)

0d45ed7

carmocca force-pushed the 1.9.4-draft branch from df40318 to 0d45ed7 Compare February 28, 2023 01:48

Borda approved these changes Feb 28, 2023

View reviewed changes

awaelchli approved these changes Feb 28, 2023

View reviewed changes

ethanwharris added 2 commits February 28, 2023 12:52

[App] Add support for plugins to return actions (#16832)

c5c2d1b

[App] Fix environment check with command redirection (#16883)

83b112e

carmocca changed the title ~~[WIP] Weekly patch release v1.9.4~~ Weekly patch release v1.9.4 Feb 28, 2023

mergify bot added the ready PRs ready to be merged label Feb 28, 2023

justusschock approved these changes Feb 28, 2023

View reviewed changes

lexierule merged commit 8e55ff7 into release/stable Feb 28, 2023

lexierule deleted the 1.9.4-draft branch February 28, 2023 16:52

Borda mentioned this pull request Mar 7, 2023

Update CHANGELOG after the v1.9.4 release #16906

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly patch release v1.9.4 #16884

Weekly patch release v1.9.4 #16884

carmocca commented Feb 27, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading

codecov bot commented Feb 27, 2023 •

edited

Loading

Weekly patch release v1.9.4 #16884

Weekly patch release v1.9.4 #16884

Conversation

carmocca commented Feb 27, 2023 • edited by github-actions bot Loading

What does this PR do?

github-actions bot commented Feb 27, 2023 • edited Loading

🌩️ Required checks status: Pending 🟡

Groups summary

codecov bot commented Feb 27, 2023 • edited Loading

Codecov Report

carmocca commented Feb 27, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 27, 2023 •

edited

Loading

codecov bot commented Feb 27, 2023 •

edited

Loading