Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update colossalai version in Dockerfile #16766

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Update colossalai version in Dockerfile #16766

merged 1 commit into from
Feb 15, 2023

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 15, 2023 •
edited by github-actions bot
Loading

What does this PR do?

This was missed in #16747

cc @carmocca @akihironitta @Borda

@awaelchli awaelchli added the ci Continuous Integration label Feb 15, 2023
@awaelchli awaelchli added this to the v1.9.x milestone Feb 15, 2023
@awaelchli awaelchli marked this pull request as ready for review February 15, 2023 13:53
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.11, 11.3.1) success ✅
build-cuda (3.9, 1.12, 11.6.1) success ✅
build-cuda (3.9, 1.13, 11.7.1) success ✅
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.13) success ✅
build-NGC skipped ❓
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.7.1) success ✅
build-xla (3.8, 1.12) success ✅

These checks are required after the changes to dockers/base-cuda/Dockerfile.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 15, 2023
Borda
Borda approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they just released a new one but fine to ignore :)

dockers/base-cuda/Dockerfile Show resolved Hide resolved
@justusschock justusschock enabled auto-merge (squash) February 15, 2023 13:59
@awaelchli
Copy link
Contributor Author

Probot doesnt allow us to only change the docker file. Wants to build NGC as well 🤔

@carmocca
Copy link
Contributor

There seems to be an issue where it's not pulling the latest statuses. Feel free to force merge

@lexierule lexierule merged commit 3b7f186 into master Feb 15, 2023
@lexierule lexierule deleted the ci/docker-colossal branch February 15, 2023 19:20
awaelchli added a commit that referenced this pull request Feb 16, 2023
@awaelchli
Update colossalai version in Dockerfile (#16766)
20b890a 
update docker
lexierule pushed a commit that referenced this pull request Feb 21, 2023
@awaelchli @lexierule
Update colossalai version in Dockerfile (#16766)
a27af0f 
update docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

Assignees
No one assigned
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.
5 participants
@awaelchli @carmocca @Borda @justusschock @lexierule