Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-1.7: Backports for 1.7.2 #43667

Merged
merged 25 commits into from
Jan 28, 2022
Merged

release-1.7: Backports for 1.7.2 #43667

merged 25 commits into from
Jan 28, 2022

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Jan 5, 2022 •
edited
Loading

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

aviatesk and others added 8 commits January 5, 2022 16:15
@aviatesk @KristofferC
fix current_exceptions docstring and annotate arguments (#41897)
d82a907 
(cherry picked from commit 398d1a0)
@DilumAluthge @KristofferC
Base.runtests: set a temporary Pkg depot path (#42358)
e13f8bf 
(cherry picked from commit 2c9e051)
@Keno @KristofferC
win32: Fix SEH frame sentinel (#43570)
6619d65 
The last entry sentinel for Win64 SEH is `~0L` not NULL. Apparently
this doesn't cause issues on windows proper, but does crash wine.
Arguably if Windows doesn't have issues then we should just fix
this in wine, but since we control the source and nobody else
ever seems to have run into this, let's just fix it and save
the good Wine folks some headache. Fixes #43569.

(cherry picked from commit 722f9d4)
@DilumAluthge @KristofferC
Base.runtests: unset JULIA_PROJECT and JULIA_LOAD_PATH (#43575)
118d245 
(cherry picked from commit f61eb87)
@staticfloat @KristofferC
Change shm_open() calling ABI on aarch64 Darwin (#43516)
f4a0c7c 
Beacuse `shm_open()` is a variadic function, if we don't declare it as
such, the kernel receives trash as the `permissions` value, which
occasionally results in errors when creating shared memory segments.
This did not happen on `x86_64` because the calling convention doesn't
change so much between variadic and non-vadiadic functions.

(cherry picked from commit ffed6b8)
@IanButterworth @KristofferC
Missing package add prompt: Restrict which exprs to search in (#43457)
3b7e9f0 
(cherry picked from commit 8f192bd)
@KristofferC
move enabling fast TLS from jl_load_repl to `jl_load_libjulia_inter…
04d16b2 
…nal` (#43655)

(cherry picked from commit f397b8b)
@tkf @KristofferC
Use a valid atomic ordering in docstring (#43643)
85fc5c9 
(cherry picked from commit 26b5736)
@KristofferC KristofferC added the release Release management and versioning. label Jan 5, 2022
vchuravy and others added 17 commits January 7, 2022 11:16
@vchuravy
Do not fail if fastpath for TLS can't be found
04f6a38 
Prevents loading of `libjulia-codegen` into `opt`.

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit 0402dfa)
@aviatesk @KristofferC
fix atomic getfield with boundcheck on interpreter (#43602)
2c65083 
(cherry picked from commit 368a8f3)
@Sacha0 @KristofferC
Lift expensive Regex construction from DateFormat method body.
aa342bc 
Constructing the Regex touched in this commit can represent a
significant fraction (e.g. half or better) of the runtime of
the DateFormat method touched in this commit. To make this
DateFormat method more efficient, let's lift that Regex
construction out of that method body.

(cherry picked from commit 7fb5bb8)
@N5N3 @KristofferC
Resolve instability from reducedim_init (#43467)
c7110e0 
(cherry picked from commit 4b83a64)
@dnadlinger @KristofferC
Fix Base.StackTraces.lookup(C_NULL - 1) on macOS 12 (#43612)
e528136 
See comment in diff for explanation. This fixes test/stacktraces.jl
on aarch64 macOS 12, and according to an OpenJDK issue where they
ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193,
probably also x86_64 macOS 12.

(cherry picked from commit 7f27dea)
@KristofferC
add const keyword to broadcasted AndAnd (#43483)
aca122f 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
(cherry picked from commit 4409c82)
@dkarrasch @KristofferC
Fix sparse array setindex(::Int, ::Vector) (#43678)
6043be5 
(cherry picked from commit dc61f29)
@fredrikekre @KristofferC
Fix (add|set)env to keep currently set dir for the command, fixes #42131
4280bc4 
. (#43276)

(cherry picked from commit f53de73)
@simeonschaub @KristofferC
fix #25678: return matters for generated functions (#40778)
cecf27a 
Just explicitely check for `CodeInfo` objects and use an explicit
`return` in this case inside the `@generated` macro.

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
(cherry picked from commit 92c84bf)
@Keno @KristofferC
late-gc-lowering: Prevent infinite recursion (#42445)
f476e1d 
Phi nodes are allowed to recursively depend on themselves, so
we need to keep track of which ones we have seen to avoid an
infinite recursion here. Apparently this doesn't usually come
up, but I did see if with tsan enabled.

(cherry picked from commit a9a1d80)
@Keno @KristofferC
Spell out ~0L literal (#43579)
fea2e84 
To avoid the compiler potentially picking the wrong size depending on standards versions.

(cherry picked from commit e8d1167)
@KristofferC
run a temp cleanup after the precompilation step (#43761)
65a11e1 
Fixes #43702

(cherry picked from commit 9d05e7b)
@mkitti @KristofferC
Fix #43004 by commenting out broken throw tests (#43739)
9e5ad01 
(cherry picked from commit 89f2332)
@devmotion @KristofferC
Use GlobalRef of Core.CodeInfo in @generated (#43823)
f5d02a1 
Co-authored-by: Simeon Schaub <schaub@mit.edu>
(cherry picked from commit 8536522)
@vtjnash @KristofferC
macOS: workaround a dyld/libunwind deadlock issue since 12.1
d52235f 
Apple reintroduced the old bug that we previously worked around in
fad04d3 with a similar patch to this.

This is needed anywhere that we may attempt to stop threads.

Fixes #43578

(cherry picked from commit 2939272)
@vtjnash @KristofferC
macOS: extend the workaround to cover the dyld/exc_server deadlock is…
3582fd7 
…sue, since 12.1

Later, we should probably switch to using mach_exc_server generated from
`mig mach_exc.defs`.

(cherry picked from commit 267b124)
@vchuravy @KristofferC
[LateLowerGC] Change undef FCA into zeroinit (#43867)
5e045a1 
(cherry picked from commit 88b1f92)
@KristofferC

This comment has been minimized.

Sign in to view
@KristofferC

This comment has been minimized.

Sign in to view
@KristofferC

This comment has been minimized.

Sign in to view
@nanosoldier

This comment has been minimized.

Sign in to view
@nanosoldier

This comment has been minimized.

Sign in to view
@vtjnash

This comment has been minimized.

Sign in to view
@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs=":release-1.7")

@KristofferC
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.7")

@nanosoldier
Copy link
Collaborator

Something went wrong when running your job:

NanosoldierError: error when preparing/pushing to report repo: failed process: Process(setenv(`git push`; dir="/nanosoldier/workdir/NanosoldierReports"), ProcessExited(1)) [1]

Unfortunately, the logs could not be uploaded.

@vtjnash
Copy link
Member

vtjnash commented Jan 26, 2022

https://github.com/JuliaCI/NanosoldierReports/tree/master/benchmark/by_hash/a712044_vs_3f024fd/report.md

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["ADNLPModels", "AutomotiveVisualization", "BioMASS", "Caesar", "CanopyLayers", "CompressedSensing", "DistributedArrays", "GadgetIO", "GaussianMixtureAlignment", "GraphNeuralNetworks", "IntervalConstraintProgramming", "JuMP", "LoopThrottle", "MadNLP", "MiniQhull", "NavAbilitySDK", "OceanRobots", "OptimalTransmissionRouting", "Probably", "RoME", "SLEEFPirates", "SpatialJackknife", "Spectra", "StaticKernels", "StochasticRounding", "SymmetryReduceBZ", "TensorKit", "TraitSimulation", "VoronoiGraph", "WavePropBase"], vs = ":release-1.7")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC KristofferC merged commit 75c1e04 into release-1.7 Jan 28, 2022
@KristofferC KristofferC deleted the backports-release-1.7 branch January 28, 2022 13:07
@vtjnash vtjnash mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.