-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pushing to vector after 3-arg ldiv! #43510
Conversation
This doesn't seem like a good fix. It fixes the specific problem, but doesn't do anything to address the more general problem which is that you can't resize a |
Sure, but that's a much more general issue. This solves a specific concrete issue that causes problems elsewhere (SciML/LinearSolve.jl#81) |
In that case, can you add a |
Is there a big problem to having separate methods? It does make it simpler, and avoids intermediate views |
In the failing test (which fails for Julia v1.6+), the untouched matrix-method in the function ldiv!(Y::AbstractMatrix, A::Factorization, B::AbstractMatrix)
require_one_based_indexing(Y, B)
m, n = size(A, 1), size(A, 2)
if m > n
Bc = copy(B)
ldiv!(A, Bc)
return copyto!(Y, view(Bc, 1:n, :))
else
copyto!(view(Y, 1:m, :), view(B, 1:m, :))
return ldiv!(A, Y)
end
end At least with this change the failing test fails no more. Not sure if we need more size checks here, actually. |
Backporting to v1.6 requires special care due to the |
Thanks @dkarrasch!
I think changing it to |
Shall we just merge or rebase before merging? |
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Fixes #43507. Fixes #29852.