[LateLowerGC] Change undef FCA into zeroinit #43867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43798
@vtjnash and I discussed this offline. The long-term proper fix maybe to not from FCA entirely in the front-end.
For now we settled on the fact that we can scan the IR and make sure that formed FCA are not undef initialized,
but instead zero initialized, ensuring that LateLowerGC didn't synthesize a use of an undef value.
An alternative proposal by me was to use
ValueTracking
to see if something is proven undef, but that seemed rather costlyand more invasive.