Change shm_open() calling ABI on aarch64 Darwin
#43516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beacuse `shm_open()` is a variadic function, if we don't declare it as such, the kernel receives trash as the `permissions` value, which occasionally results in errors when creating shared memory segments. This did not happen on `x86_64` because the calling convention doesn't change so much between variadic and non-vadiadic functions.
staticfloat
added
system:mac
|
Fixes #43464 |
vtjnash
approved these changes
Dec 22, 2021
|
LGTM (I'm seeing the same issue on aarch64-darwin); CI failures are spurious. |
31 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jan 5, 2022
Beacuse `shm_open()` is a variadic function, if we don't declare it as such, the kernel receives trash as the `permissions` value, which occasionally results in errors when creating shared memory segments. This did not happen on `x86_64` because the calling convention doesn't change so much between variadic and non-vadiadic functions. (cherry picked from commit ffed6b8)
23 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Beacuse `shm_open()` is a variadic function, if we don't declare it as such, the kernel receives trash as the `permissions` value, which occasionally results in errors when creating shared memory segments. This did not happen on `x86_64` because the calling convention doesn't change so much between variadic and non-vadiadic functions.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Beacuse `shm_open()` is a variadic function, if we don't declare it as such, the kernel receives trash as the `permissions` value, which occasionally results in errors when creating shared memory segments. This did not happen on `x86_64` because the calling convention doesn't change so much between variadic and non-vadiadic functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beacuse
shm_open()is a variadic function, if we don't declare it assuch, the kernel receives trash as the
permissionsvalue, whichoccasionally results in errors when creating shared memory segments.
This did not happen on
x86_64because the calling convention doesn'tchange so much between variadic and non-vadiadic functions.