[MOB-2585] - No message view for inbox #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabenkoru
reviewed
Feb 25, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java
Outdated
Show resolved
Hide resolved
vbabenkoru
reviewed
Feb 25, 2021
vbabenkoru
reviewed
Feb 25, 2021
1. When passed with title and text in bundle, IterableInboxFragment can take that text and override default title and message text 2. Visibility are toggled based on inbox count on every update 3. Inbox Fragment XML now has two text views kept inside RelativeLayout beside recyclerView instead of just having RecyclerView
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
18edd70 to
439f391
Compare
Added suggested changes.
Updating the default strings to be empty strings.
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
4ac44db to
6d933f9
Compare
vbabenkoru
reviewed
Feb 26, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java
Outdated
Show resolved
Hide resolved
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
6d933f9 to
e939ecd
Compare
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
e939ecd to
08f3560
Compare
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 70.35% 70.72% +0.36%
==========================================
Files 60 60
Lines 3701 3727 +26
Branches 430 433 +3
==========================================
+ Hits 2604 2636 +32
+ Misses 832 828 -4
+ Partials 265 263 -2
Continue to review full report at Codecov.
|
1. Added test to verify if the text passed is visible on empty inbox screen 2. Passing the arguments to IterableInboxFragment in in-case customer just initializes IterableInboxActivity instead of IterableInboxFragment 3. Modified basic test method as it tries to click on empty list which we now hide if its empty 4. Parsing and assinging the strings in onCreate instead of onStart of fragment
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
08f3560 to
5a24d19
Compare
vbabenkoru
reviewed
Feb 27, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxActivity.java
Outdated
Show resolved
Hide resolved
vbabenkoru
reviewed
Feb 27, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java
Outdated
Show resolved
Hide resolved
vbabenkoru
reviewed
Mar 1, 2021
vbabenkoru
reviewed
Mar 1, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java
Outdated
Show resolved
Hide resolved
vbabenkoru
reviewed
Mar 1, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java
Outdated
Show resolved
Hide resolved
vbabenkoru
reviewed
Mar 1, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxActivity.java
Outdated
Show resolved
Hide resolved
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
c2720b7 to
09f0a2f
Compare
vbabenkoru
reviewed
Mar 2, 2021
iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java
Outdated
Show resolved
Hide resolved
Added recommended changes 1. Added constructor to IterableInboxFragment. Now setArguments wont overwrite arguments set by newInstance method. 2. Removed `this` while referencing global variable 3. Updated message TextView in XML to have layout below Title textView. No more hardcoded placement of views. 4. Added nullable notations
Ayyanchira
force-pushed
the
MOB-2585-No-Message-View-for-Inbox
branch
from
09f0a2f to
023521d
Compare
vbabenkoru
approved these changes
Mar 2, 2021
app/src/androidTest/java/com/iterable/iterableapi/MainActivityTest.java
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/iterable/iterableapi/MainActivityTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Babenko <victor@iterable.com>
Ayyanchira
added a commit
that referenced
this pull request
Mar 30, 2021
[MOB-2585] - No message view for inbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
https://iterable.atlassian.net/browse/MOB-2585
✏️ Description
IterableInboxAcitivityinstead ofIterableInboxFragment, we still relay the bundle arguments toIterableInboxFragmentinternally. So bundle passed toIterableInboxActivitywill still work.