Skip to content

Commit 741ee73

Browse files
AyyanchiraAyyanchira
authored
Merge 3efbaef into 423b507 
2 parents 423b507 + 3efbaef commit 741ee73

File tree

7 files changed

+98
-17
lines changed

7 files changed

+98
-17
lines changed

‎app/src/androidTest/java/com/iterable/iterableapi/MainActivityTest.java‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,18 @@ public void testSwipeToDeleteInApp() throws Exception {
233233
onView(withText("Tips and tricks 2")).check(doesNotExist());
234234
}
235235

236+
@Test
237+
public void testNoMessagesTitleAndText() throws Exception {
238+
Intent intent = new Intent();
239+
String noMessageTitle = "OOPSY";
240+
String noMessageBody = "No messages for you";
241+
intent.putExtra(IterableConstants.NO_MESSAGES_TITLE, noMessageTitle);
242+
intent.putExtra(IterableConstants.NO_MESSAGES_BODY, noMessageBody);
243+
rule.launchActivity(intent);
244+
onView(withText(noMessageTitle)).check(matches(isDisplayed()));
245+
onView(withText(noMessageBody)).check(matches(isDisplayed()));
246+
}
247+
236248

237249
static class Matchers{
238250
public static Matcher<View> withListSize (final int size) {
@@ -283,4 +295,4 @@ static void waitFor(int ms) {
283295
Assert.fail(e.getMessage());
284296
}
285297
}
286-
}
298+
}

‎app/src/androidTest/java/com/iterable/iterableapi/testapp/InboxUITest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ protected void beforeActivityLaunched() {
3030

3131
@Test
3232
public void basicTest() {
33-
onView(withId(R.id.list)).perform(click());
3433
assertNotNull(rule.getActivity());
3534
}
3635
}

‎app/src/test/java/com/iterable/iterableapi/InboxUITest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ protected void beforeActivityLaunched() {
2929

3030
@Test
3131
public void basicTest() {
32-
onView(withId(R.id.list)).perform(click());
3332
assertNotNull(rule.getActivity());
3433
}
3534
}

‎iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxActivity.java‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import androidx.annotation.Nullable;
66
import androidx.appcompat.app.AppCompatActivity;
77

8+
import com.iterable.iterableapi.IterableConstants;
89
import com.iterable.iterableapi.IterableLogger;
910
import com.iterable.iterableapi.ui.R;
1011

@@ -37,7 +38,14 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
3738
if (inboxModeExtra instanceof InboxMode) {
3839
inboxMode = (InboxMode) inboxModeExtra;
3940
}
40-
inboxFragment = IterableInboxFragment.newInstance(inboxMode, itemLayoutId);
41+
String noMessageTitle = null;
42+
String noMessageBody = null;
43+
Bundle extraBundle = getIntent().getExtras();
44+
if (extraBundle != null) {
45+
noMessageTitle = extraBundle.getString(IterableConstants.NO_MESSAGES_TITLE, null);
46+
noMessageBody = extraBundle.getString(IterableConstants.NO_MESSAGES_BODY, null);
47+
}
48+
inboxFragment = IterableInboxFragment.newInstance(inboxMode, itemLayoutId, noMessageTitle, noMessageBody);
4149

4250
if (intent.getStringExtra(ACTIVITY_TITLE) != null) {
4351
setTitle(intent.getStringExtra(ACTIVITY_TITLE));

‎iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java‎

Lines changed: 43 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,12 @@
1212
import android.view.LayoutInflater;
1313
import android.view.View;
1414
import android.view.ViewGroup;
15+
import android.widget.RelativeLayout;
16+
import android.widget.TextView;
1517

1618
import com.iterable.iterableapi.IterableActivityMonitor;
1719
import com.iterable.iterableapi.IterableApi;
20+
import com.iterable.iterableapi.IterableConstants;
1821
import com.iterable.iterableapi.IterableInAppDeleteActionType;
1922
import com.iterable.iterableapi.IterableInAppLocation;
2023
import com.iterable.iterableapi.IterableInAppManager;
@@ -45,6 +48,11 @@ public class IterableInboxFragment extends Fragment implements IterableInAppMana
4548

4649
private InboxMode inboxMode = InboxMode.POPUP;
4750
private @LayoutRes int itemLayoutId = R.layout.iterable_inbox_item;
51+
private String noMessagesTitle;
52+
private String noMessagesBody;
53+
TextView noMessagesTitleTextView;
54+
TextView noMessagesBodyTextView;
55+
RecyclerView recyclerView;
4856

4957
private final SessionManager sessionManager = new SessionManager();
5058
private IterableInboxAdapterExtension adapterExtension = new DefaultAdapterExtension();
@@ -72,10 +80,16 @@ public class IterableInboxFragment extends Fragment implements IterableInAppMana
7280
* @return {@link IterableInboxFragment} instance
7381
*/
7482
@NonNull public static IterableInboxFragment newInstance(@NonNull InboxMode inboxMode, @LayoutRes int itemLayoutId) {
83+
return newInstance(inboxMode, itemLayoutId, null, null);
84+
}
85+
86+
@NonNull public static IterableInboxFragment newInstance(@NonNull InboxMode inboxMode, @LayoutRes int itemLayoutId, @Nullable String noMessagesTitle, @Nullable String noMessagesBody) {
7587
IterableInboxFragment inboxFragment = new IterableInboxFragment();
7688
Bundle bundle = new Bundle();
7789
bundle.putSerializable(INBOX_MODE, inboxMode);
7890
bundle.putInt(ITEM_LAYOUT_ID, itemLayoutId);
91+
bundle.putString(IterableConstants.NO_MESSAGES_TITLE, noMessagesTitle);
92+
bundle.putString(IterableConstants.NO_MESSAGES_BODY, noMessagesBody);
7993
inboxFragment.setArguments(bundle);
8094

8195
return inboxFragment;
@@ -153,15 +167,26 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
153167
if (arguments.getInt(ITEM_LAYOUT_ID, 0) != 0) {
154168
itemLayoutId = arguments.getInt(ITEM_LAYOUT_ID);
155169
}
170+
if (arguments.getString(IterableConstants.NO_MESSAGES_TITLE) != null) {
171+
noMessagesTitle = arguments.getString(IterableConstants.NO_MESSAGES_TITLE);
172+
}
173+
if (arguments.getString(IterableConstants.NO_MESSAGES_BODY) != null) {
174+
noMessagesBody = arguments.getString(IterableConstants.NO_MESSAGES_BODY);
175+
}
156176
}
157177

158-
RecyclerView view = (RecyclerView) inflater.inflate(R.layout.iterable_inbox_fragment, container, false);
159-
view.setLayoutManager(new LinearLayoutManager(getContext()));
178+
RelativeLayout relativeLayout = (RelativeLayout) inflater.inflate(R.layout.iterable_inbox_fragment, container, false);
179+
recyclerView = relativeLayout.findViewById(R.id.list);
180+
recyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
160181
IterableInboxAdapter adapter = new IterableInboxAdapter(IterableApi.getInstance().getInAppManager().getInboxMessages(), IterableInboxFragment.this, adapterExtension, comparator, filter, dateMapper);
161-
view.setAdapter(adapter);
182+
recyclerView.setAdapter(adapter);
183+
noMessagesTitleTextView = relativeLayout.findViewById(R.id.emptyInboxTitle);
184+
noMessagesBodyTextView = relativeLayout.findViewById(R.id.emptyInboxMessage);
185+
noMessagesTitleTextView.setText(noMessagesTitle);
186+
noMessagesBodyTextView.setText(noMessagesBody);
162187
ItemTouchHelper itemTouchHelper = new ItemTouchHelper(new IterableInboxTouchHelper(getContext(), adapter));
163-
itemTouchHelper.attachToRecyclerView(view);
164-
return view;
188+
itemTouchHelper.attachToRecyclerView(recyclerView);
189+
return relativeLayout;
165190
}
166191

167192
@Override
@@ -213,9 +238,21 @@ private void stopSession() {
213238
}
214239

215240
private void updateList() {
216-
RecyclerView recyclerView = (RecyclerView) getView();
217241
IterableInboxAdapter adapter = (IterableInboxAdapter) recyclerView.getAdapter();
218242
adapter.setInboxItems(IterableApi.getInstance().getInAppManager().getInboxMessages());
243+
handleEmptyInbox(adapter);
244+
}
245+
246+
private void handleEmptyInbox(IterableInboxAdapter adapter) {
247+
if (adapter.getItemCount() == 0) {
248+
noMessagesTitleTextView.setVisibility(View.VISIBLE);
249+
noMessagesBodyTextView.setVisibility(View.VISIBLE);
250+
recyclerView.setVisibility(View.INVISIBLE);
251+
} else {
252+
noMessagesTitleTextView.setVisibility(View.INVISIBLE);
253+
noMessagesBodyTextView.setVisibility(View.INVISIBLE);
254+
recyclerView.setVisibility(View.VISIBLE);
255+
}
219256
}
220257

221258
@Override

‎iterableapi-ui/src/main/res/layout/iterable_inbox_fragment.xml‎

Lines changed: 30 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,34 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<androidx.recyclerview.widget.RecyclerView xmlns:android="http://schemas.android.com/apk/res/android"
3-
xmlns:app="http://schemas.android.com/apk/res-auto"
2+
3+
<RelativeLayout xmlns:app="http://schemas.android.com/apk/res-auto"
44
xmlns:tools="http://schemas.android.com/tools"
5-
android:id="@+id/list"
5+
xmlns:android="http://schemas.android.com/apk/res/android"
6+
android:id="@+id/inboxFragmentLayout"
67
android:name="com.iterable.iterableapi.ui.InboxFragment"
7-
android:layout_width="match_parent"
88
android:layout_height="match_parent"
9-
app:layoutManager="LinearLayoutManager"
10-
tools:context=".inbox.IterableInboxFragment"
11-
tools:listitem="@layout/iterable_inbox_item" />
9+
android:layout_width="match_parent"
10+
tools:context=".inbox.IterableInboxFragment">
11+
12+
<androidx.recyclerview.widget.RecyclerView
13+
android:id="@+id/list"
14+
android:layout_width="match_parent"
15+
android:layout_height="match_parent"
16+
app:layoutManager="LinearLayoutManager"
17+
tools:listitem="@layout/iterable_inbox_item" />
18+
19+
<TextView
20+
android:id="@+id/emptyInboxTitle"
21+
android:layout_width="match_parent"
22+
android:layout_height="wrap_content"
23+
android:layout_centerInParent="true"
24+
android:gravity="center"
25+
android:textSize="18sp"
26+
android:textStyle="bold" />
27+
28+
<TextView
29+
android:layout_below="@id/emptyInboxTitle"
30+
android:id="@+id/emptyInboxMessage"
31+
android:layout_width="match_parent"
32+
android:layout_height="wrap_content"
33+
android:gravity="center" />
34+
</RelativeLayout>

‎iterableapi/src/main/java/com/iterable/iterableapi/IterableConstants.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,4 +244,7 @@ public final class IterableConstants {
244244
public static final String ITBL_PLATFORM_ANDROID = "Android";
245245
public static final String ITBL_KEY_SDK_VERSION_NUMBER = BuildConfig.ITERABLE_SDK_VERSION;
246246
public static final String ITBL_SYSTEM_VERSION = "systemVersion";
247+
248+
public static final String NO_MESSAGES_TITLE = "noMessagesTitle";
249+
public static final String NO_MESSAGES_BODY = "noMessagesBody";
247250
}

0 commit comments

Comments
 (0)