Revision 4

Added recommended changes
1. Added constructor to IterableInboxFragment. Now setArguments wont overwrite arguments set by newInstance method.
2. Removed `this` while referencing global variable

Author: Ayyanchira

iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxActivity.java

@@ -5,6 +5,7 @@
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AppCompatActivity;
 
+import com.iterable.iterableapi.IterableConstants;
 import com.iterable.iterableapi.IterableLogger;
 import com.iterable.iterableapi.ui.R;
 
@@ -37,8 +38,14 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
             if (inboxModeExtra instanceof InboxMode) {
                 inboxMode = (InboxMode) inboxModeExtra;
             }
-            inboxFragment = IterableInboxFragment.newInstance(inboxMode, itemLayoutId);
-            inboxFragment.setArguments(intent.getExtras());
+            String noMessageTitle = "";
+            String noMessageBody = "";
+            Bundle extraBundle = getIntent().getExtras();
+            if (extraBundle != null) {
+                noMessageTitle = extraBundle.getString(IterableConstants.NO_MESSAGES_TITLE, "");
+                noMessageBody = extraBundle.getString(IterableConstants.NO_MESSAGES_BODY, "");
+            }
+            inboxFragment = IterableInboxFragment.newInstance(inboxMode, itemLayoutId, noMessageTitle, noMessageBody);
 
             if (intent.getStringExtra(ACTIVITY_TITLE) != null) {
                 setTitle(intent.getStringExtra(ACTIVITY_TITLE));

iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java

@@ -80,10 +80,16 @@ public class IterableInboxFragment extends Fragment implements IterableInAppMana
      * @return {@link IterableInboxFragment} instance
      */
     @NonNull public static IterableInboxFragment newInstance(@NonNull InboxMode inboxMode, @LayoutRes int itemLayoutId) {
+        return newInstance(inboxMode, itemLayoutId, "", "");
+    }
+
+    @NonNull public static IterableInboxFragment newInstance(@NonNull InboxMode inboxMode, @LayoutRes int itemLayoutId, String noMessagesTitle, String noMessagesBody) {
         IterableInboxFragment inboxFragment = new IterableInboxFragment();
         Bundle bundle = new Bundle();
         bundle.putSerializable(INBOX_MODE, inboxMode);
         bundle.putInt(ITEM_LAYOUT_ID, itemLayoutId);
+        bundle.putString(IterableConstants.NO_MESSAGES_TITLE, noMessagesTitle);
+        bundle.putString(IterableConstants.NO_MESSAGES_BODY, noMessagesBody);
         inboxFragment.setArguments(bundle);
 
         return inboxFragment;
@@ -162,10 +168,10 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
                 itemLayoutId = arguments.getInt(ITEM_LAYOUT_ID);
             }
             if (arguments.getString(IterableConstants.NO_MESSAGES_TITLE) != null) {
-                this.noMessagesTitle = arguments.getString(IterableConstants.NO_MESSAGES_TITLE);
+                noMessagesTitle = arguments.getString(IterableConstants.NO_MESSAGES_TITLE);
             }
             if (arguments.getString(IterableConstants.NO_MESSAGES_BODY) != null) {
-                this.noMessagesBody = arguments.getString(IterableConstants.NO_MESSAGES_BODY);
+                noMessagesBody = arguments.getString(IterableConstants.NO_MESSAGES_BODY);
             }
         }