Revision 3

1. Added test to verify if the text passed is visible on empty inbox screen
2. Passing the arguments to IterableInboxFragment in in-case customer just initializes IterableInboxActivity instead of IterableInboxFragment
3. Modified basic test method as it tries to click on empty list which we now hide if its empty
4. Parsing and assinging the strings in onCreate instead of onStart of fragment

Author: Ayyanchira

app/src/androidTest/java/com/iterable/iterableapi/MainActivityTest.java

@@ -233,6 +233,18 @@ public void testSwipeToDeleteInApp() throws Exception {
         onView(withText("Tips and tricks 2")).check(doesNotExist());
     }
 
+    @Test
+    public void testNoMessagesTitleAndText() throws Exception {
+        Intent intent = new Intent();
+        String noMessageTitle = "OOPSY";
+        String noMessageBody = "No messages for you";
+        intent.putExtra(IterableConstants.NO_MESSAGES_TITLE,noMessageTitle);
+        intent.putExtra(IterableConstants.NO_MESSAGES_BODY,noMessageBody);
+        rule.launchActivity(intent);
+        onView(withText(noMessageTitle)).check(matches(isDisplayed()));
+        onView(withText(noMessageBody)).check(matches(isDisplayed()));
+    }
+
 
     static class Matchers{
         public static Matcher<View> withListSize (final int size) {

app/src/androidTest/java/com/iterable/iterableapi/testapp/InboxUITest.java

@@ -30,7 +30,6 @@ protected void beforeActivityLaunched() {
 
     @Test
     public void basicTest() {
-        onView(withId(R.id.list)).perform(click());
         assertNotNull(rule.getActivity());
     }
 }

iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxActivity.java

@@ -38,6 +38,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
                 inboxMode = (InboxMode) inboxModeExtra;
             }
             inboxFragment = IterableInboxFragment.newInstance(inboxMode, itemLayoutId);
+            inboxFragment.setArguments(intent.getExtras());
 
             if (intent.getStringExtra(ACTIVITY_TITLE) != null) {
                 setTitle(intent.getStringExtra(ACTIVITY_TITLE));

iterableapi-ui/src/main/java/com/iterable/iterableapi/ui/inbox/IterableInboxFragment.java

@@ -174,17 +174,15 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
         recyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
         IterableInboxAdapter adapter = new IterableInboxAdapter(IterableApi.getInstance().getInAppManager().getInboxMessages(), IterableInboxFragment.this, adapterExtension, comparator, filter, dateMapper);
         recyclerView.setAdapter(adapter);
+        noMessagesTitleTextView = relativeLayout.findViewById(R.id.emptyInboxTitle);
+        noMessagesBodyTextView = relativeLayout.findViewById(R.id.emptyInboxMessage);
+        noMessagesTitleTextView.setText(noMessagesTitle);
+        noMessagesBodyTextView.setText(noMessagesBody);
         ItemTouchHelper itemTouchHelper = new ItemTouchHelper(new IterableInboxTouchHelper(getContext(), adapter));
         itemTouchHelper.attachToRecyclerView(recyclerView);
         return relativeLayout.getRootView();
     }
 
-    @Override
-    public void onStart() {
-        super.onStart();
-        updateEmptyInboxMessage();
-    }
-
     @Override
     public void onResume() {
         super.onResume();
@@ -193,13 +191,6 @@ public void onResume() {
         startSession();
     }
 
-    private void updateEmptyInboxMessage() {
-        noMessagesTitleTextView = getView().findViewById(R.id.emptyInboxTitle);
-        noMessagesBodyTextView = getView().findViewById(R.id.emptyInboxMessage);
-        noMessagesTitleTextView.setText(noMessagesTitle);
-        noMessagesBodyTextView.setText(noMessagesBody);
-    }
-
     @Override
     public void onPause() {
         IterableApi.getInstance().getInAppManager().removeListener(this);