Skip to content

Conversation

@BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 6744: go/store/nbs: store.go: Clean up how we update hasCache so that we only update it after successfully writing the memtable.
  • 6740: Support for DOLT_COMMITTER_DATE and DOLT_AUTHOR_DATE environment vars
    These two new environment vars perform the same function as GIT_COMMITTER_DATE and GIT_AUTHOR_DATE, respectively. They set the two timestamps associated with newly created commits on dolt commit and dolt merge.
    Setting these two environment variables allows the deterministic creation of commit hashes, as requested in dolt merge doesn't produce deterministic hashes dolthub/dolt#6724

go-mysql-server

  • 2041: not panic on Star.IsNullable()
    This reverts AliasedExpr.InputExression should be compared case insensitive dolthub/go-mysql-server#2039 because the fix was not correct choice for the issue HEX(*) fails with panic dolthub/dolt#6659.
  • 2039: AliasedExpr.InputExression should be compared case insensitive
  • 2038: error msg for invalid reference to non-existent table or column in existing view
    It catches invalid reference to non-existent table or column in existing view. This includes SELECT queries on a view that references table or column that was removed or renamed.
    Note: For now, It does not catch references to invalid functions or users without appropriate privilege cases and queries other than SELECT queries.
    Fixes: Renaming a table breaks views using that table dolthub/dolt#6691
  • 2032: fix order by on unioned schemas
    When unioning two SELECT statements that have different column types, we would get -1 during assignExecIndexes, resulting in a panic.
    This PR fixes the issue by matching on unqualified column names when we don't have an exact match.
    We don't find these matches because the second table has an unqualified alias over the column name because it is wrapping it in a convert node.
  • 2030: unskipping fixed tests
    We have many tests that are marked skip/broken, but they are working now.
    This PR unskips and cleans up some of these skipped tests.
  • 2022: TPC-X query plan tests
    Added schemas, stats, query plans for:
    • TPC-H
    • TPC-DS
    • IMDB join planning benchmark
      Added plangen to auto-update the tests.
      We cannot parse all of the TPC-DS query plans yet. I saw some ROLLUP and aggregation validation errors.
      Excluding data ops benchmark because the plans are not interesting.
  • 1786: support event execution
    This PR adds event execution logic implementing EventScheduler interface in the engine.
    Notes:

vitess

  • 278: fix unsigned flag for COM_STMT_EXECUTE when new_params_bind_flag is set
    In the previous implementation, we assumed that the way the MySQL Protocol specifies Column Definitions is the same as how it specifies parameter types for COM_STMT_EXECUTE. The difference lies specifically in the flags that come after the field type.
    When reading/writing a field type (for a Column Definition), MySQL expects/writes a 1 byte wide enum_field_type followed by a 2 byte wide Column Definition Flag.
    However, when reading a COM_STMT_EXECUTE payload (that specifies parameters through new_params_bind_flag), MySQL indicates parameter_types with the same 1 byte wide enum_field_type followed by a 1 byte wide flag that indicates signedness.
    So basically, read 0x80 for COM_STMT_EXECUTE parameters, but read/write 0x20 for field_types/column definitions.
    I'm assuming MySQL does it this way because the majority of the Column Definition Flags are nonsensical/meaningless when paired up with parameters to prepared statements. Regardless, this was a subtle bug, and we should have tests for parsing COM_STMT_EXECUTE with new_params_bind_flag.
    Fixes Out of Range for bigint unsigned with question mark dolthub/dolt#6728
  • 277: Allow parsing of CREATE TABLE t AS (...) UNION (...)
    This allows parsing of CREATE TABLE AS statements when the expression being used to create the table is a set operation like UNION, INTERSECT, or EXCEPT.
    The "AS" keyword is typically optional. But this change only allows set ops to be used with CREATE ... AS when the AS is explicit. This is to avoid an ambiguity in the current grammar when attempting to parse CREATE TABLE t (, where what follows could be a set op or a table definition. Fully matching MySQL's spec here would require rewriting our grammar to avoid this ambiguity, which is outside the scope of the PR. However, this PR makes us strictly more correct than we were before.
  • 276: Allow parsing of SECONDARY_ENGINE = NULL
    This is a simple change to allow parsing a NULL value for the SECONDARY_ENGINE attribute for CREATE TABLE and ALTER TABLE statements.

Closed Issues

  • 6724: dolt merge doesn't produce deterministic hashes
  • 6728: Out of Range for bigint unsigned with question mark
  • 6691: Renaming a table breaks views using that table
  • 5498: Support CREATE EVENT statement
  • 6393: Handle schema merge for column and FK drop automatically
  • 6406: FOUND_ROWS() returns incorrect results
  • 6343: Produce a diff of two arbitrary queries
  • 6572: Prepared statements cache AST nodes
  • 1782: Error 1105: -128 out of range for BIGINT UNSIGNED

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Sep 29, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 29, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 29, 2023
Merged via the queue into Homebrew:master with commit c2f3c02 Sep 29, 2023
@BrewTestBot BrewTestBot deleted the bump-dolt-1.17.1 branch September 29, 2023 23:26
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants