TPC-X query plan tests #2022
Merged
TPC-X query plan tests #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Sep 27, 2023
| } | ||
|
|
||
| var err error | ||
| switch cmd { |
There was a problem hiding this comment.
Seems like a useless extra switch
| path: enginetest/queries/tpch_plans.go | ||
| - name: TpccPlanTests | ||
| path: enginetest/queries/tpcc_plans.go | ||
| # - name: TpcdsPlanTests |
There was a problem hiding this comment.
we can't parse them yet
enginetest/scriptgen/setup/helper.go
Outdated
| JoinsSetup [][]SetupScript | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
What's the point of this init block, why can't these be declared inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added schemas, stats, query plans for:
Added
plangento auto-update the tests.We cannot parse all of the TPC-DS query plans yet. I saw some ROLLUP and aggregation validation errors.
Excluding data ops benchmark because the plans are not interesting.