fix order by on unioned schemas
#2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Sep 27, 2023
| } | ||
| } | ||
| n = unqualify(n) | ||
| for i := len(s.columns) - 1; i >= 0; i-- { |
There was a problem hiding this comment.
can we not recurse on getIdx(unqualify(n))? documenting that this is only correct for references to SetOp outputs is also useful
There was a problem hiding this comment.
If unqualified n isn't in the scope, then I think that results in an infinite loop.
There was a problem hiding this comment.
kk, what about unqualifying the comparison columns? Does the union Schema have qualified columns?
added 2 commits
September 27, 2023 10:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unioning two
SELECTstatements that have different column types, we would get -1 duringassignExecIndexes, resulting in a panic.This PR fixes the issue by matching on unqualified column names when we don't have an exact match.
We don't find these matches because the second table has an unqualified alias over the column name because it is wrapping it in a convert node.