Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Sep 25, 2023

We have many tests that are marked skip/broken, but they are working now.
This PR unskips and cleans up some of these skipped tests.

@max-hoffman
Copy link
Contributor

is this ready for review?

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! now we just need to find the next set of joins we don't support

@jycor jycor merged commit a2bfc15 into main Sep 27, 2023
@jycor jycor deleted the james/join branch September 27, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants