-
Notifications
You must be signed in to change notification settings - Fork 306
Propagate grizzly http span in filters if nothing is active #9016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026087
Total [baseline] (8.583 s) : 0, 8583481
Agent [candidate] (1.028 s) : 0, 1027964
Total [candidate] (8.567 s) : 0, 8566818
section iast
Agent [baseline] (1.153 s) : 0, 1152777
Total [baseline] (9.226 s) : 0, 9226439
Agent [candidate] (1.162 s) : 0, 1162352
Total [candidate] (9.257 s) : 0, 9256926
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.358 ms) : 0, 686358
BytebuddyAgent [candidate] (688.597 ms) : 0, 688597
GlobalTracer [baseline] (242.295 ms) : 0, 242295
GlobalTracer [candidate] (243.13 ms) : 0, 243130
AppSec [baseline] (56.616 ms) : 0, 56616
AppSec [candidate] (58.699 ms) : 0, 58699
Debugger [baseline] (7.753 ms) : 0, 7753
Debugger [candidate] (6.971 ms) : 0, 6971
Remote Config [baseline] (688.451 µs) : 0, 688
Remote Config [candidate] (671.319 µs) : 0, 671
Telemetry [baseline] (11.32 ms) : 0, 11320
Telemetry [candidate] (9.035 ms) : 0, 9035
section iast
BytebuddyAgent [baseline] (806.059 ms) : 0, 806059
BytebuddyAgent [candidate] (813.067 ms) : 0, 813067
GlobalTracer [baseline] (232.082 ms) : 0, 232082
GlobalTracer [candidate] (233.794 ms) : 0, 233794
IAST [baseline] (26.018 ms) : 0, 26018
IAST [candidate] (26.463 ms) : 0, 26463
AppSec [baseline] (53.116 ms) : 0, 53116
AppSec [candidate] (53.335 ms) : 0, 53335
Debugger [baseline] (5.982 ms) : 0, 5982
Debugger [candidate] (5.953 ms) : 0, 5953
Remote Config [baseline] (604.877 µs) : 0, 605
Remote Config [candidate] (614.719 µs) : 0, 615
Telemetry [baseline] (8.011 ms) : 0, 8011
Telemetry [candidate] (8.095 ms) : 0, 8095
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1024810
Total [baseline] (10.644 s) : 0, 10644479
Agent [candidate] (1.029 s) : 0, 1029402
Total [candidate] (10.669 s) : 0, 10669003
section appsec
Agent [baseline] (1.183 s) : 0, 1183255
Total [baseline] (10.777 s) : 0, 10777405
Agent [candidate] (1.179 s) : 0, 1178687
Total [candidate] (10.774 s) : 0, 10773996
section iast
Agent [baseline] (1.159 s) : 0, 1158702
Total [baseline] (10.891 s) : 0, 10890677
Agent [candidate] (1.155 s) : 0, 1154987
Total [candidate] (10.891 s) : 0, 10891001
section profiling
Agent [baseline] (1.275 s) : 0, 1274666
Total [baseline] (11.022 s) : 0, 11022011
Agent [candidate] (1.27 s) : 0, 1270451
Total [candidate] (10.987 s) : 0, 10986544
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.939 ms) : 0, 685939
BytebuddyAgent [candidate] (688.169 ms) : 0, 688169
GlobalTracer [baseline] (242.411 ms) : 0, 242411
GlobalTracer [candidate] (243.594 ms) : 0, 243594
AppSec [baseline] (58.044 ms) : 0, 58044
AppSec [candidate] (59.496 ms) : 0, 59496
Debugger [baseline] (8.632 ms) : 0, 8632
Debugger [candidate] (6.879 ms) : 0, 6879
Remote Config [baseline] (675.266 µs) : 0, 675
Remote Config [candidate] (667.643 µs) : 0, 668
Telemetry [baseline] (8.242 ms) : 0, 8242
Telemetry [candidate] (9.625 ms) : 0, 9625
section appsec
BytebuddyAgent [baseline] (709.471 ms) : 0, 709471
BytebuddyAgent [candidate] (708.611 ms) : 0, 708611
GlobalTracer [baseline] (237.081 ms) : 0, 237081
GlobalTracer [candidate] (234.769 ms) : 0, 234769
IAST [baseline] (22.041 ms) : 0, 22041
IAST [candidate] (21.82 ms) : 0, 21820
AppSec [baseline] (180.035 ms) : 0, 180035
AppSec [candidate] (179.11 ms) : 0, 179110
Debugger [baseline] (5.853 ms) : 0, 5853
Debugger [candidate] (5.797 ms) : 0, 5797
Remote Config [baseline] (616.674 µs) : 0, 617
Remote Config [candidate] (604.677 µs) : 0, 605
Telemetry [baseline] (7.381 ms) : 0, 7381
Telemetry [candidate] (7.213 ms) : 0, 7213
section iast
BytebuddyAgent [baseline] (810.969 ms) : 0, 810969
BytebuddyAgent [candidate] (807.625 ms) : 0, 807625
GlobalTracer [baseline] (232.954 ms) : 0, 232954
GlobalTracer [candidate] (232.498 ms) : 0, 232498
IAST [baseline] (29.27 ms) : 0, 29270
IAST [candidate] (26.059 ms) : 0, 26059
AppSec [baseline] (50.013 ms) : 0, 50013
AppSec [candidate] (53.264 ms) : 0, 53264
Debugger [baseline] (5.928 ms) : 0, 5928
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (607.312 µs) : 0, 607
Remote Config [candidate] (624.803 µs) : 0, 625
Telemetry [baseline] (8.034 ms) : 0, 8034
Telemetry [candidate] (8.072 ms) : 0, 8072
section profiling
BytebuddyAgent [baseline] (678.435 ms) : 0, 678435
BytebuddyAgent [candidate] (677.852 ms) : 0, 677852
GlobalTracer [baseline] (362.317 ms) : 0, 362317
GlobalTracer [candidate] (361.51 ms) : 0, 361510
AppSec [baseline] (62.875 ms) : 0, 62875
AppSec [candidate] (62.207 ms) : 0, 62207
Debugger [baseline] (6.183 ms) : 0, 6183
Debugger [candidate] (6.154 ms) : 0, 6154
Remote Config [baseline] (703.214 µs) : 0, 703
Remote Config [candidate] (711.044 µs) : 0, 711
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.145 ms) : 0, 8145
ProfilingAgent [baseline] (107.181 ms) : 0, 107181
ProfilingAgent [candidate] (105.186 ms) : 0, 105186
Profiling [baseline] (107.205 ms) : 0, 107205
Profiling [candidate] (105.211 ms) : 0, 105211
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section baseline
no_agent (4.329 ms) : 4272, 4385
. : milestone, 4329,
iast (9.038 ms) : 8894, 9182
. : milestone, 9038,
iast_FULL (13.525 ms) : 13262, 13789
. : milestone, 13525,
iast_GLOBAL (10.093 ms) : 9904, 10282
. : milestone, 10093,
profiling (8.875 ms) : 8731, 9020
. : milestone, 8875,
tracing (7.669 ms) : 7557, 7781
. : milestone, 7669,
section candidate
no_agent (4.429 ms) : 4379, 4479
. : milestone, 4429,
iast (9.163 ms) : 9013, 9313
. : milestone, 9163,
iast_FULL (13.977 ms) : 13695, 14258
. : milestone, 13977,
iast_GLOBAL (10.115 ms) : 9934, 10297
. : milestone, 10115,
profiling (8.528 ms) : 8382, 8674
. : milestone, 8528,
tracing (7.461 ms) : 7350, 7572
. : milestone, 7461,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section baseline
no_agent (37.699 ms) : 37402, 37997
. : milestone, 37699,
appsec (45.392 ms) : 44987, 45798
. : milestone, 45392,
code_origins (44.974 ms) : 44615, 45333
. : milestone, 44974,
iast (42.783 ms) : 42406, 43161
. : milestone, 42783,
profiling (47.641 ms) : 47212, 48069
. : milestone, 47641,
tracing (42.265 ms) : 41936, 42594
. : milestone, 42265,
section candidate
no_agent (35.936 ms) : 35651, 36221
. : milestone, 35936,
appsec (46.858 ms) : 46442, 47275
. : milestone, 46858,
code_origins (44.717 ms) : 44351, 45083
. : milestone, 44717,
iast (44.65 ms) : 44258, 45043
. : milestone, 44650,
profiling (47.34 ms) : 46917, 47763
. : milestone, 47340,
tracing (42.799 ms) : 42445, 43153
. : milestone, 42799,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.395 ms) : 2346, 2443
. : milestone, 2395,
iast (2.177 ms) : 2116, 2239
. : milestone, 2177,
iast_GLOBAL (2.208 ms) : 2147, 2269
. : milestone, 2208,
profiling (2.034 ms) : 1983, 2084
. : milestone, 2034,
tracing (1.989 ms) : 1941, 2036
. : milestone, 1989,
section candidate
no_agent (1.469 ms) : 1458, 1480
. : milestone, 1469,
appsec (2.391 ms) : 2342, 2439
. : milestone, 2391,
iast (2.189 ms) : 2127, 2251
. : milestone, 2189,
iast_GLOBAL (2.215 ms) : 2153, 2276
. : milestone, 2215,
profiling (2.019 ms) : 1970, 2068
. : milestone, 2019,
tracing (1.991 ms) : 1944, 2038
. : milestone, 1991,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~7c18ffeb02, baseline=1.51.0-SNAPSHOT~83532cfd23
dateFormat X
axisFormat %s
section baseline
no_agent (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
appsec (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
iast (18.836 s) : 18836000, 18836000
. : milestone, 18836000,
iast_GLOBAL (18.043 s) : 18043000, 18043000
. : milestone, 18043000,
profiling (15.765 s) : 15765000, 15765000
. : milestone, 15765000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
section candidate
no_agent (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.863 s) : 18863000, 18863000
. : milestone, 18863000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (15.296 s) : 15296000, 15296000
. : milestone, 15296000,
tracing (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What Does This Do
In latest version of mule, the mule instrumentation is not able to attach the span it creates to the incoming http request. This because when the event context is created, there is no active span.
Since that event context is created within a grizzly filter, we are now ensuring that, in case there is no active span, we activate the one created for the http request beforehand.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]