-
Notifications
You must be signed in to change notification settings - Fork 305
Extract Ratpack json body response schemas #9013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manuel-alvarez-alvarez
wants to merge
1
commit into
malvarez/play-response-extraction
Choose a base branch
from
malvarez/ratpack-response-extraction
base: malvarez/play-response-extraction
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract Ratpack json body response schemas #9013
manuel-alvarez-alvarez
wants to merge
1
commit into
malvarez/play-response-extraction
from
malvarez/ratpack-response-extraction
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
686764c
to
7e087e5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 39 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023068
Total [baseline] (8.536 s) : 0, 8535879
Agent [candidate] (1.029 s) : 0, 1029351
Total [candidate] (8.51 s) : 0, 8510476
section iast
Agent [baseline] (1.156 s) : 0, 1156159
Total [baseline] (9.274 s) : 0, 9274488
Agent [candidate] (1.164 s) : 0, 1163674
Total [candidate] (9.202 s) : 0, 9201659
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.392 ms) : 0, 683392
BytebuddyAgent [candidate] (685.396 ms) : 0, 685396
GlobalTracer [baseline] (240.777 ms) : 0, 240777
GlobalTracer [candidate] (241.064 ms) : 0, 241064
AppSec [baseline] (59.089 ms) : 0, 59089
AppSec [candidate] (62.157 ms) : 0, 62157
Debugger [baseline] (6.825 ms) : 0, 6825
Debugger [candidate] (6.172 ms) : 0, 6172
Remote Config [baseline] (712.521 µs) : 0, 713
Remote Config [candidate] (653.37 µs) : 0, 653
Telemetry [baseline] (8.959 ms) : 0, 8959
Telemetry [candidate] (10.468 ms) : 0, 10468
section iast
BytebuddyAgent [baseline] (805.538 ms) : 0, 805538
BytebuddyAgent [candidate] (810.921 ms) : 0, 810921
GlobalTracer [baseline] (232.586 ms) : 0, 232586
GlobalTracer [candidate] (232.451 ms) : 0, 232451
IAST [baseline] (24.639 ms) : 0, 24639
IAST [candidate] (28.638 ms) : 0, 28638
AppSec [baseline] (55.202 ms) : 0, 55202
AppSec [candidate] (53.658 ms) : 0, 53658
Debugger [baseline] (5.986 ms) : 0, 5986
Debugger [candidate] (5.99 ms) : 0, 5990
Remote Config [baseline] (609.666 µs) : 0, 610
Remote Config [candidate] (581.951 µs) : 0, 582
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (7.906 ms) : 0, 7906
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042179
Total [baseline] (10.785 s) : 0, 10784590
Agent [candidate] (1.03 s) : 0, 1030439
Total [candidate] (10.665 s) : 0, 10665342
section appsec
Agent [baseline] (1.178 s) : 0, 1178105
Total [baseline] (10.679 s) : 0, 10679023
Agent [candidate] (1.192 s) : 0, 1191831
Total [candidate] (10.861 s) : 0, 10861185
section iast
Agent [baseline] (1.16 s) : 0, 1160490
Total [baseline] (10.867 s) : 0, 10866665
Agent [candidate] (1.17 s) : 0, 1169571
Total [candidate] (10.877 s) : 0, 10877099
section profiling
Agent [baseline] (1.283 s) : 0, 1282515
Total [baseline] (11.134 s) : 0, 11133962
Agent [candidate] (1.283 s) : 0, 1283262
Total [candidate] (10.904 s) : 0, 10903730
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.357 ms) : 0, 698357
BytebuddyAgent [candidate] (685.505 ms) : 0, 685505
GlobalTracer [baseline] (244.126 ms) : 0, 244126
GlobalTracer [candidate] (241.307 ms) : 0, 241307
AppSec [baseline] (56.889 ms) : 0, 56889
AppSec [candidate] (60.356 ms) : 0, 60356
Debugger [baseline] (6.24 ms) : 0, 6240
Debugger [candidate] (6.277 ms) : 0, 6277
Remote Config [baseline] (745.163 µs) : 0, 745
Remote Config [candidate] (674.868 µs) : 0, 675
Telemetry [baseline] (12.032 ms) : 0, 12032
Telemetry [candidate] (12.851 ms) : 0, 12851
section appsec
BytebuddyAgent [baseline] (707.672 ms) : 0, 707672
BytebuddyAgent [candidate] (714.542 ms) : 0, 714542
GlobalTracer [baseline] (235.594 ms) : 0, 235594
GlobalTracer [candidate] (237.025 ms) : 0, 237025
IAST [baseline] (21.833 ms) : 0, 21833
IAST [candidate] (21.923 ms) : 0, 21923
AppSec [baseline] (175.701 ms) : 0, 175701
AppSec [candidate] (180.775 ms) : 0, 180775
Debugger [baseline] (5.905 ms) : 0, 5905
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (618.489 µs) : 0, 618
Remote Config [candidate] (647.688 µs) : 0, 648
Telemetry [baseline] (7.285 ms) : 0, 7285
Telemetry [candidate] (7.37 ms) : 0, 7370
section iast
BytebuddyAgent [baseline] (810.431 ms) : 0, 810431
BytebuddyAgent [candidate] (815.413 ms) : 0, 815413
GlobalTracer [baseline] (232.66 ms) : 0, 232660
GlobalTracer [candidate] (232.479 ms) : 0, 232479
IAST [baseline] (27.108 ms) : 0, 27108
IAST [candidate] (27.28 ms) : 0, 27280
AppSec [baseline] (51.482 ms) : 0, 51482
AppSec [candidate] (55.966 ms) : 0, 55966
Debugger [baseline] (5.933 ms) : 0, 5933
Debugger [candidate] (6.074 ms) : 0, 6074
Remote Config [baseline] (587.107 µs) : 0, 587
Remote Config [candidate] (596.895 µs) : 0, 597
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (8.032 ms) : 0, 8032
section profiling
BytebuddyAgent [baseline] (685.938 ms) : 0, 685938
BytebuddyAgent [candidate] (680.414 ms) : 0, 680414
GlobalTracer [baseline] (363.108 ms) : 0, 363108
GlobalTracer [candidate] (362.329 ms) : 0, 362329
AppSec [baseline] (62.445 ms) : 0, 62445
AppSec [candidate] (65.229 ms) : 0, 65229
Debugger [baseline] (6.173 ms) : 0, 6173
Debugger [candidate] (6.212 ms) : 0, 6212
Remote Config [baseline] (647.324 µs) : 0, 647
Remote Config [candidate] (662.335 µs) : 0, 662
Telemetry [baseline] (8.305 ms) : 0, 8305
Telemetry [candidate] (8.279 ms) : 0, 8279
ProfilingAgent [baseline] (104.501 ms) : 0, 104501
ProfilingAgent [candidate] (109.121 ms) : 0, 109121
Profiling [baseline] (104.526 ms) : 0, 104526
Profiling [candidate] (109.146 ms) : 0, 109146
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 0 metrics, 10 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section baseline
no_agent (8.695 ms) : 8671, 8719
. : milestone, 8695,
appsec (39.513 ms) : 38980, 40046
. : milestone, 39513,
code_origins (53.306 ms) : 52182, 54430
. : milestone, 53306,
iast (47.454 ms) : 46782, 48127
. : milestone, 47454,
profiling (11.005 ms) : 10930, 11081
. : milestone, 11005,
tracing (8.241 ms) : 8214, 8268
. : milestone, 8241,
section candidate
no_agent (76.89 ms) : 75255, 78525
. : milestone, 76890,
appsec (96.475 ms) : 93665, 99286
. : milestone, 96475,
code_origins (114.259 ms) : 107749, 120768
. : milestone, 114259,
iast (101.893 ms) : 98240, 105545
. : milestone, 101893,
profiling (89.274 ms) : 87100, 91448
. : milestone, 89274,
tracing (83.216 ms) : 81376, 85056
. : milestone, 83216,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.394 ms) : 2345, 2442
. : milestone, 2394,
iast (2.182 ms) : 2121, 2243
. : milestone, 2182,
iast_GLOBAL (2.231 ms) : 2170, 2293
. : milestone, 2231,
profiling (2.048 ms) : 1998, 2099
. : milestone, 2048,
tracing (2.003 ms) : 1956, 2050
. : milestone, 2003,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.402 ms) : 2353, 2451
. : milestone, 2402,
iast (2.186 ms) : 2124, 2248
. : milestone, 2186,
iast_GLOBAL (2.235 ms) : 2173, 2297
. : milestone, 2235,
profiling (2.452 ms) : 2293, 2611
. : milestone, 2452,
tracing (2.014 ms) : 1966, 2062
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~7e087e5fb5, baseline=1.50.0-SNAPSHOT~e0a1fc0e75
dateFormat X
axisFormat %s
section baseline
no_agent (15.316 s) : 15316000, 15316000
. : milestone, 15316000,
appsec (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
iast (18.67 s) : 18670000, 18670000
. : milestone, 18670000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
profiling (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
tracing (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
section candidate
no_agent (15.258 s) : 15258000, 15258000
. : milestone, 15258000,
appsec (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
iast (18.416 s) : 18416000, 18416000
. : milestone, 18416000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
. : milestone, 17950000,
profiling (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
tracing (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
inst: ratpack
Ratpack instrumentation
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds response body extraction for Ratpack JSON endpoints to enable automatic API schema discovery and protection by the Web Application Firewall (WAF).
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57915