-
Notifications
You must be signed in to change notification settings - Fork 303
Migrate publishing namespace to Maven Central #8807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 53 metrics, 14 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023245
Total [baseline] (10.483 s) : 0, 10483254
Agent [candidate] (1.021 s) : 0, 1021448
Total [candidate] (10.489 s) : 0, 10488637
section appsec
Agent [baseline] (1.159 s) : 0, 1158785
Total [baseline] (10.66 s) : 0, 10660068
Agent [candidate] (1.166 s) : 0, 1165520
Total [candidate] (10.64 s) : 0, 10639882
section iast
Agent [baseline] (1.151 s) : 0, 1151439
Total [baseline] (10.937 s) : 0, 10937213
Agent [candidate] (1.155 s) : 0, 1154742
Total [candidate] (10.929 s) : 0, 10928848
section profiling
Agent [baseline] (1.262 s) : 0, 1261924
Total [baseline] (10.872 s) : 0, 10872459
Agent [candidate] (1.281 s) : 0, 1280732
Total [candidate] (10.854 s) : 0, 10854016
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.556 ms) : 0, 686556
BytebuddyAgent [candidate] (683.778 ms) : 0, 683778
GlobalTracer [baseline] (240.978 ms) : 0, 240978
GlobalTracer [candidate] (240.241 ms) : 0, 240241
AppSec [baseline] (54.587 ms) : 0, 54587
AppSec [candidate] (54.489 ms) : 0, 54489
Debugger [baseline] (7.634 ms) : 0, 7634
Debugger [candidate] (10.463 ms) : 0, 10463
Remote Config [baseline] (715.168 µs) : 0, 715
Remote Config [candidate] (692.172 µs) : 0, 692
Telemetry [baseline] (9.114 ms) : 0, 9114
Telemetry [candidate] (8.251 ms) : 0, 8251
section appsec
BytebuddyAgent [baseline] (699.274 ms) : 0, 699274
BytebuddyAgent [candidate] (703.299 ms) : 0, 703299
GlobalTracer [baseline] (235.817 ms) : 0, 235817
GlobalTracer [candidate] (237.61 ms) : 0, 237610
AppSec [baseline] (175.393 ms) : 0, 175393
AppSec [candidate] (175.646 ms) : 0, 175646
Debugger [baseline] (5.911 ms) : 0, 5911
Debugger [candidate] (6.006 ms) : 0, 6006
Remote Config [baseline] (625.449 µs) : 0, 625
Remote Config [candidate] (631.977 µs) : 0, 632
Telemetry [baseline] (7.372 ms) : 0, 7372
Telemetry [candidate] (7.831 ms) : 0, 7831
IAST [baseline] (21.717 ms) : 0, 21717
IAST [candidate] (21.665 ms) : 0, 21665
section iast
BytebuddyAgent [baseline] (802.78 ms) : 0, 802780
BytebuddyAgent [candidate] (807.889 ms) : 0, 807889
GlobalTracer [baseline] (232.032 ms) : 0, 232032
GlobalTracer [candidate] (230.86 ms) : 0, 230860
AppSec [baseline] (50.187 ms) : 0, 50187
AppSec [candidate] (50.931 ms) : 0, 50931
Debugger [baseline] (5.863 ms) : 0, 5863
Debugger [candidate] (5.868 ms) : 0, 5868
Remote Config [baseline] (594.486 µs) : 0, 594
Remote Config [candidate] (586.225 µs) : 0, 586
Telemetry [baseline] (7.847 ms) : 0, 7847
Telemetry [candidate] (7.839 ms) : 0, 7839
IAST [baseline] (28.514 ms) : 0, 28514
IAST [candidate] (27.355 ms) : 0, 27355
section profiling
ProfilingAgent [baseline] (102.737 ms) : 0, 102737
ProfilingAgent [candidate] (109.899 ms) : 0, 109899
BytebuddyAgent [baseline] (672.955 ms) : 0, 672955
BytebuddyAgent [candidate] (673.486 ms) : 0, 673486
GlobalTracer [baseline] (358.934 ms) : 0, 358934
GlobalTracer [candidate] (378.211 ms) : 0, 378211
AppSec [baseline] (61.52 ms) : 0, 61520
AppSec [candidate] (53.829 ms) : 0, 53829
Debugger [baseline] (6.242 ms) : 0, 6242
Debugger [candidate] (6.098 ms) : 0, 6098
Remote Config [baseline] (654.064 µs) : 0, 654
Remote Config [candidate] (654.976 µs) : 0, 655
Telemetry [baseline] (8.135 ms) : 0, 8135
Telemetry [candidate] (8.097 ms) : 0, 8097
Profiling [baseline] (102.761 ms) : 0, 102761
Profiling [candidate] (109.925 ms) : 0, 109925
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1024933
Total [baseline] (8.659 s) : 0, 8659168
Agent [candidate] (1.035 s) : 0, 1035147
Total [candidate] (8.654 s) : 0, 8654008
section iast
Agent [baseline] (1.156 s) : 0, 1155637
Total [baseline] (9.236 s) : 0, 9235805
Agent [candidate] (1.147 s) : 0, 1147299
Total [candidate] (9.206 s) : 0, 9205770
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.146 s) : 0, 1146104
Total [baseline] (9.176 s) : 0, 9176060
Agent [candidate] (1.157 s) : 0, 1156509
Total [candidate] (9.206 s) : 0, 9206404
section iast_TELEMETRY_OFF
Agent [baseline] (1.144 s) : 0, 1144195
Total [baseline] (9.2 s) : 0, 9199503
Agent [candidate] (1.141 s) : 0, 1140937
Total [candidate] (9.218 s) : 0, 9218301
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.997 ms) : 0, 685997
BytebuddyAgent [candidate] (695.639 ms) : 0, 695639
GlobalTracer [baseline] (240.812 ms) : 0, 240812
GlobalTracer [candidate] (241.601 ms) : 0, 241601
AppSec [baseline] (54.768 ms) : 0, 54768
AppSec [candidate] (54.849 ms) : 0, 54849
Debugger [baseline] (9.09 ms) : 0, 9090
Debugger [candidate] (8.448 ms) : 0, 8448
Remote Config [baseline] (707.983 µs) : 0, 708
Remote Config [candidate] (707.563 µs) : 0, 708
Telemetry [baseline] (9.844 ms) : 0, 9844
Telemetry [candidate] (9.937 ms) : 0, 9937
section iast
BytebuddyAgent [baseline] (806.915 ms) : 0, 806915
BytebuddyAgent [candidate] (801.025 ms) : 0, 801025
GlobalTracer [baseline] (231.389 ms) : 0, 231389
GlobalTracer [candidate] (229.856 ms) : 0, 229856
IAST [baseline] (25.4 ms) : 0, 25400
IAST [candidate] (27.529 ms) : 0, 27529
AppSec [baseline] (53.087 ms) : 0, 53087
AppSec [candidate] (50.975 ms) : 0, 50975
Debugger [baseline] (5.963 ms) : 0, 5963
Debugger [candidate] (5.918 ms) : 0, 5918
Remote Config [baseline] (598.65 µs) : 0, 599
Remote Config [candidate] (597.601 µs) : 0, 598
Telemetry [baseline] (7.86 ms) : 0, 7860
Telemetry [candidate] (7.884 ms) : 0, 7884
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.86 ms) : 0, 799860
BytebuddyAgent [candidate] (806.692 ms) : 0, 806692
GlobalTracer [baseline] (230.631 ms) : 0, 230631
GlobalTracer [candidate] (231.809 ms) : 0, 231809
IAST [baseline] (27.684 ms) : 0, 27684
IAST [candidate] (28.855 ms) : 0, 28855
AppSec [baseline] (50.146 ms) : 0, 50146
AppSec [candidate] (50.874 ms) : 0, 50874
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (6.011 ms) : 0, 6011
Remote Config [baseline] (604.408 µs) : 0, 604
Remote Config [candidate] (606.175 µs) : 0, 606
Telemetry [baseline] (7.893 ms) : 0, 7893
Telemetry [candidate] (7.977 ms) : 0, 7977
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.77 ms) : 0, 797770
BytebuddyAgent [candidate] (795.908 ms) : 0, 795908
GlobalTracer [baseline] (230.068 ms) : 0, 230068
GlobalTracer [candidate] (229.546 ms) : 0, 229546
IAST [baseline] (23.854 ms) : 0, 23854
IAST [candidate] (23.758 ms) : 0, 23758
AppSec [baseline] (54.607 ms) : 0, 54607
AppSec [candidate] (53.875 ms) : 0, 53875
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (5.889 ms) : 0, 5889
Remote Config [baseline] (609.03 µs) : 0, 609
Remote Config [candidate] (600.034 µs) : 0, 600
Telemetry [baseline] (7.765 ms) : 0, 7765
Telemetry [candidate] (7.796 ms) : 0, 7796
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section baseline
no_agent (381.138 µs) : 360, 403
. : milestone, 381,
iast (513.777 µs) : 492, 535
. : milestone, 514,
iast_FULL (735.059 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (555.921 µs) : 535, 577
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (525.309 µs) : 503, 548
. : milestone, 525,
iast_INACTIVE (466.123 µs) : 444, 489
. : milestone, 466,
iast_TELEMETRY_OFF (513.812 µs) : 492, 536
. : milestone, 514,
tracing (460.977 µs) : 439, 483
. : milestone, 461,
section candidate
no_agent (377.85 µs) : 358, 398
. : milestone, 378,
iast (516.53 µs) : 494, 539
. : milestone, 517,
iast_FULL (735.455 µs) : 713, 758
. : milestone, 735,
iast_GLOBAL (559.825 µs) : 538, 582
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (507.135 µs) : 484, 530
. : milestone, 507,
iast_INACTIVE (462.413 µs) : 440, 485
. : milestone, 462,
iast_TELEMETRY_OFF (517.44 µs) : 494, 540
. : milestone, 517,
tracing (455.917 µs) : 434, 478
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
. : milestone, 1346,
appsec (1.731 ms) : 1708, 1755
. : milestone, 1731,
appsec_no_iast (1.717 ms) : 1693, 1740
. : milestone, 1717,
code_origins (1.665 ms) : 1638, 1691
. : milestone, 1665,
iast (1.513 ms) : 1489, 1537
. : milestone, 1513,
profiling (1.512 ms) : 1489, 1535
. : milestone, 1512,
tracing (1.49 ms) : 1465, 1515
. : milestone, 1490,
section candidate
no_agent (1.37 ms) : 1350, 1389
. : milestone, 1370,
appsec (1.744 ms) : 1720, 1768
. : milestone, 1744,
appsec_no_iast (1.734 ms) : 1710, 1757
. : milestone, 1734,
code_origins (1.687 ms) : 1659, 1714
. : milestone, 1687,
iast (1.53 ms) : 1507, 1554
. : milestone, 1530,
profiling (1.535 ms) : 1510, 1560
. : milestone, 1535,
tracing (1.49 ms) : 1465, 1515
. : milestone, 1490,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
iast (18.776 s) : 18776000, 18776000
. : milestone, 18776000,
iast_GLOBAL (18.228 s) : 18228000, 18228000
. : milestone, 18228000,
profiling (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
tracing (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
section candidate
no_agent (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
appsec (15.218 s) : 15218000, 15218000
. : milestone, 15218000,
iast (18.638 s) : 18638000, 18638000
. : milestone, 18638000,
iast_GLOBAL (18.145 s) : 18145000, 18145000
. : milestone, 18145000,
profiling (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
tracing (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~811414a4a3, baseline=1.50.0-SNAPSHOT~43d66127d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (2.412 ms) : 2364, 2461
. : milestone, 2412,
iast (2.185 ms) : 2124, 2245
. : milestone, 2185,
iast_GLOBAL (2.229 ms) : 2168, 2290
. : milestone, 2229,
profiling (2.056 ms) : 2006, 2106
. : milestone, 2056,
tracing (2.013 ms) : 1965, 2060
. : milestone, 2013,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (2.405 ms) : 2357, 2453
. : milestone, 2405,
iast (2.197 ms) : 2136, 2257
. : milestone, 2197,
iast_GLOBAL (2.232 ms) : 2171, 2293
. : milestone, 2232,
profiling (2.056 ms) : 2006, 2106
. : milestone, 2056,
tracing (2.008 ms) : 1961, 2055
. : milestone, 2008,
|
What’s the plan to test this change? There will be a release between the deadline. Do you feel that will be enough? |
I'm thinking that the release will give a good indication of how this change is working, but ideally I can "dry run" the publishing beforehand (following this? still looking into ways this could be / if this is possible...). |
@@ -15,7 +15,7 @@ repositories { | |||
mavenContent { | |||
snapshotsOnly() | |||
} | |||
url 'https://oss.sonatype.org/content/repositories/snapshots/' | |||
url 'https://ossrh-staging-api.central.sonatype.com/content/repositories/snapshots/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference for change: https://central.sonatype.org/publish/publish-portal-ossrh-staging-api/#configuration
b0ab864
to
e8e8898
Compare
@@ -693,14 +693,16 @@ deploy_to_sonatype: | |||
when: never | |||
- if: '$CI_COMMIT_BRANCH == "master"' | |||
when: on_success | |||
- if: '$CI_COMMIT_BRANCH == "sarahchen6/migrate-to-central"' | |||
when: on_success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm deployment is successful and delete before merging
What Does This Do
Update
gradle-nexus/publish-plugin
to v2.0.0, and change URL namespaces to Central PortalMotivation
Sonatype's OSSRH is reaching end of life on June 30, 2025. We need to migrate to Maven Central ASAP.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-493