-
Notifications
You must be signed in to change notification settings - Fork 305
Fix NPE in akka-http and pekko-http integrations #9019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also fix a related issue where spans were not being finished while polling through leftover scopes.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026072
Total [baseline] (10.803 s) : 0, 10802996
Agent [candidate] (1.023 s) : 0, 1023380
Total [candidate] (10.577 s) : 0, 10577115
section appsec
Agent [baseline] (1.182 s) : 0, 1182218
Total [baseline] (10.741 s) : 0, 10740512
Agent [candidate] (1.184 s) : 0, 1184039
Total [candidate] (10.759 s) : 0, 10758799
section iast
Agent [baseline] (1.152 s) : 0, 1152490
Total [baseline] (10.822 s) : 0, 10821702
Agent [candidate] (1.158 s) : 0, 1157502
Total [candidate] (10.897 s) : 0, 10897152
section profiling
Agent [baseline] (1.267 s) : 0, 1266977
Total [baseline] (10.892 s) : 0, 10891905
Agent [candidate] (1.276 s) : 0, 1276154
Total [candidate] (10.947 s) : 0, 10947339
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.122 ms) : 0, 687122
BytebuddyAgent [candidate] (685.054 ms) : 0, 685054
GlobalTracer [baseline] (242.322 ms) : 0, 242322
GlobalTracer [candidate] (241.52 ms) : 0, 241520
AppSec [baseline] (57.426 ms) : 0, 57426
AppSec [candidate] (60.912 ms) : 0, 60912
Debugger [baseline] (7.038 ms) : 0, 7038
Debugger [candidate] (6.17 ms) : 0, 6170
Remote Config [baseline] (684.759 µs) : 0, 685
Remote Config [candidate] (664.687 µs) : 0, 665
Telemetry [baseline] (10.516 ms) : 0, 10516
Telemetry [candidate] (8.113 ms) : 0, 8113
section appsec
BytebuddyAgent [baseline] (709.244 ms) : 0, 709244
BytebuddyAgent [candidate] (711.427 ms) : 0, 711427
GlobalTracer [baseline] (235.529 ms) : 0, 235529
GlobalTracer [candidate] (235.979 ms) : 0, 235979
AppSec [baseline] (180.745 ms) : 0, 180745
AppSec [candidate] (179.942 ms) : 0, 179942
Debugger [baseline] (5.846 ms) : 0, 5846
Debugger [candidate] (5.797 ms) : 0, 5797
Remote Config [baseline] (611.534 µs) : 0, 612
Remote Config [candidate] (618.11 µs) : 0, 618
Telemetry [baseline] (7.31 ms) : 0, 7310
Telemetry [candidate] (7.283 ms) : 0, 7283
IAST [baseline] (22.126 ms) : 0, 22126
IAST [candidate] (22.081 ms) : 0, 22081
section iast
BytebuddyAgent [baseline] (806.722 ms) : 0, 806722
BytebuddyAgent [candidate] (811.477 ms) : 0, 811477
GlobalTracer [baseline] (231.551 ms) : 0, 231551
GlobalTracer [candidate] (231.73 ms) : 0, 231730
AppSec [baseline] (52.979 ms) : 0, 52979
AppSec [candidate] (50.606 ms) : 0, 50606
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.928 ms) : 0, 5928
Remote Config [baseline] (600.36 µs) : 0, 600
Remote Config [candidate] (592.964 µs) : 0, 593
Telemetry [baseline] (7.917 ms) : 0, 7917
Telemetry [candidate] (7.95 ms) : 0, 7950
IAST [baseline] (25.925 ms) : 0, 25925
IAST [candidate] (28.295 ms) : 0, 28295
section profiling
BytebuddyAgent [baseline] (675.351 ms) : 0, 675351
BytebuddyAgent [candidate] (680.815 ms) : 0, 680815
GlobalTracer [baseline] (360.55 ms) : 0, 360550
GlobalTracer [candidate] (362.298 ms) : 0, 362298
AppSec [baseline] (62.193 ms) : 0, 62193
AppSec [candidate] (62.135 ms) : 0, 62135
Debugger [baseline] (6.188 ms) : 0, 6188
Debugger [candidate] (6.156 ms) : 0, 6156
Remote Config [baseline] (696.424 µs) : 0, 696
Remote Config [candidate] (718.948 µs) : 0, 719
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (8.195 ms) : 0, 8195
ProfilingAgent [baseline] (105.329 ms) : 0, 105329
ProfilingAgent [candidate] (106.906 ms) : 0, 106906
Profiling [baseline] (105.354 ms) : 0, 105354
Profiling [candidate] (106.93 ms) : 0, 106930
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025639
Total [baseline] (8.548 s) : 0, 8548083
Agent [candidate] (1.027 s) : 0, 1027321
Total [candidate] (8.552 s) : 0, 8551620
section iast
Agent [baseline] (1.167 s) : 0, 1167211
Total [baseline] (9.247 s) : 0, 9246870
Agent [candidate] (1.16 s) : 0, 1160134
Total [candidate] (9.263 s) : 0, 9262514
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.558 ms) : 0, 686558
BytebuddyAgent [candidate] (686.102 ms) : 0, 686102
GlobalTracer [baseline] (242.174 ms) : 0, 242174
GlobalTracer [candidate] (243.087 ms) : 0, 243087
AppSec [baseline] (57.777 ms) : 0, 57777
AppSec [candidate] (58.878 ms) : 0, 58878
Debugger [baseline] (6.204 ms) : 0, 6204
Debugger [candidate] (7.208 ms) : 0, 7208
Remote Config [baseline] (678.539 µs) : 0, 679
Remote Config [candidate] (671.968 µs) : 0, 672
Telemetry [baseline] (11.286 ms) : 0, 11286
Telemetry [candidate] (10.503 ms) : 0, 10503
section iast
BytebuddyAgent [baseline] (816.926 ms) : 0, 816926
BytebuddyAgent [candidate] (812.528 ms) : 0, 812528
GlobalTracer [baseline] (234.402 ms) : 0, 234402
GlobalTracer [candidate] (232.729 ms) : 0, 232729
AppSec [baseline] (53.633 ms) : 0, 53633
AppSec [candidate] (52.375 ms) : 0, 52375
Debugger [baseline] (6.001 ms) : 0, 6001
Debugger [candidate] (5.989 ms) : 0, 5989
Remote Config [baseline] (624.294 µs) : 0, 624
Remote Config [candidate] (616.173 µs) : 0, 616
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.044 ms) : 0, 8044
IAST [baseline] (26.478 ms) : 0, 26478
IAST [candidate] (26.931 ms) : 0, 26931
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section baseline
no_agent (38.13 ms) : 37831, 38430
. : milestone, 38130,
appsec (48.637 ms) : 48206, 49068
. : milestone, 48637,
code_origins (46.103 ms) : 45718, 46489
. : milestone, 46103,
iast (44.398 ms) : 44008, 44789
. : milestone, 44398,
profiling (50.749 ms) : 50262, 51235
. : milestone, 50749,
tracing (43.817 ms) : 43459, 44176
. : milestone, 43817,
section candidate
no_agent (37.742 ms) : 37448, 38036
. : milestone, 37742,
appsec (48.167 ms) : 47738, 48597
. : milestone, 48167,
code_origins (45.971 ms) : 45581, 46361
. : milestone, 45971,
iast (45.467 ms) : 45066, 45868
. : milestone, 45467,
profiling (49.17 ms) : 48681, 49658
. : milestone, 49170,
tracing (44.574 ms) : 44201, 44948
. : milestone, 44574,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section baseline
no_agent (4.372 ms) : 4316, 4428
. : milestone, 4372,
iast (9.26 ms) : 9109, 9411
. : milestone, 9260,
iast_FULL (14.055 ms) : 13777, 14333
. : milestone, 14055,
iast_GLOBAL (10.26 ms) : 10077, 10443
. : milestone, 10260,
profiling (9.102 ms) : 8956, 9248
. : milestone, 9102,
tracing (7.434 ms) : 7323, 7544
. : milestone, 7434,
section candidate
no_agent (4.386 ms) : 4336, 4436
. : milestone, 4386,
iast (9.745 ms) : 9585, 9904
. : milestone, 9745,
iast_FULL (13.724 ms) : 13454, 13993
. : milestone, 13724,
iast_GLOBAL (10.336 ms) : 10156, 10516
. : milestone, 10336,
profiling (9.391 ms) : 9235, 9548
. : milestone, 9391,
tracing (8.134 ms) : 8008, 8259
. : milestone, 8134,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.4 ms) : 2352, 2448
. : milestone, 2400,
iast (2.189 ms) : 2127, 2250
. : milestone, 2189,
iast_GLOBAL (2.237 ms) : 2176, 2299
. : milestone, 2237,
profiling (2.024 ms) : 1975, 2073
. : milestone, 2024,
tracing (2.022 ms) : 1975, 2070
. : milestone, 2022,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.411 ms) : 2362, 2460
. : milestone, 2411,
iast (2.189 ms) : 2128, 2250
. : milestone, 2189,
iast_GLOBAL (2.227 ms) : 2166, 2289
. : milestone, 2227,
profiling (2.047 ms) : 1997, 2098
. : milestone, 2047,
tracing (2.001 ms) : 1954, 2048
. : milestone, 2001,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~1991117330, baseline=1.51.0-SNAPSHOT~60c30c276e
dateFormat X
axisFormat %s
section baseline
no_agent (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
appsec (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
iast (19.151 s) : 19151000, 19151000
. : milestone, 19151000,
iast_GLOBAL (18.066 s) : 18066000, 18066000
. : milestone, 18066000,
profiling (15.339 s) : 15339000, 15339000
. : milestone, 15339000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
section candidate
no_agent (15.57 s) : 15570000, 15570000
. : milestone, 15570000,
appsec (14.655 s) : 14655000, 14655000
. : milestone, 14655000,
iast (18.975 s) : 18975000, 18975000
. : milestone, 18975000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
. : milestone, 18052000,
profiling (15.142 s) : 15142000, 15142000
. : milestone, 15142000,
tracing (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Additional Notes
Also fix a related issue where spans were not being finished while polling through leftover scopes.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]