Variant Trimming

[Holli-Git]

Summary

None

Purpose of change

With #79482 now merged, we have a more concrete basis for what variants are and aren't acceptable. We've had cases of over-variantization with a few items. The problem with excessive variants is that it makes each variant less and less unique, eventually making it pointless. It also gives extra work to translators.

Describe the solution

Trims down a few item variants.
Pants: Removes a lot of essentially duplicate colors, no point specifying if pants are cream colored vs beige.
Stockings: Removes a lot of excessive patterning, making the patterned ones into just striped, dotted, and floral patterns. Converts them to more general colors, and removes a few that were too similar.
Chewing gums: Renames them to a more compact name, and trims down the flavors to more common ones.
Plushies: Culls this list a lot, as lots of plushies were overly specific, and also have animals where you'd struggle to decide which animal it is, like the crocodile-adjacent plushies.
Smartphone cases: Most of these were horror movie cases, which feels weirdly specific. Trims them down to a few colors and variants.
Holy symbols: This is most likely the most controversial one. A lot of the symbols were just name of religion + symbol, with seemingly no regard for how rare, or if the religion even has a widespread symbol to begin with. Simplifies them to just the 4 main religions. It now has one symbol for a fairly wide spread of religions, instead of many variants for different denominations of Christianity. This still allows for representation, still keeping the variant count reasonable.

Describe alternatives you've considered

Leaving as is and hoping it doesn't get any worse.

Testing

Loaded, works fine. These puppies don't need migrations! Hoorah!

Additional context

Please feel free to suggest any other items which you feel are over-varianted, or if you think a variant was wrongly removed.

[Cupidatis]

Maybe condoms.

[Holli-Git]

Maybe condoms.

Mmm, that's been through the ringer before with #74891 and #74935 so I'm unsure about that. Which ones do you find don't fit?

[Cupidatis]

Mmm, that's been through the ringer before with #74891 and #74935 so I'm unsure about that. Which ones do you find don't fit?

Using 2025-01-23-0518 and still finding flavored and ribbed variants... Android.
Oh wait. Looked #74935 well... I'm using condoms for emergency liquid container in game, so all this names are irritating me for expanding my inventory.

[Holli-Git]

Oh wait. Looked #74935 well... I'm using condoms for emergency liquid container in game, so all this names are irritating me for expanding my inventory.

Yeah, I'm afraid that's an issue I can't tackle. Variants stacking would solve this, but that's outside my skillset.

[Maleclypse]

Changes requested

[Bone-blood-moss]

Why? We need more varints I really don't see any duplicates so that can't be it. Why you're removing it to we barely have any variants. Are we going back to 1 item to represent the variant? Thought we went away from that because code bloat hundreds of the same item Instead of variance?

[Karol1223]

We need more varints

We really don't.

we barely have any variants

We really don't, we have hundreds, and most of them are low effort slop that's unbelievably niche

[Holli-Git]

Why? We need more varints I really don't see any duplicates so that can't be it. Why you're removing it to we barely have any variants. Are we going back to 1 item to represent the variant? Thought we went away from that because code bloat hundreds of the same item Instead of variance?

"We barely have any" Yes, we do. Yes, lots of items don't have variants, a fair amount have some variants, but a select few have way too many variants that were not properly thought out and examined. We had a fox, and a red fox plushie. Those are the same animal. We've had two different types of camel. Is that really needed? Do people seriously look as a dromedary plush vs a camel plush and go "This is a worthwhile distinction I'm glad to have in the game", or do people just glaze over it because it's yet another plushie variant? If we just have every single plushie, ever, it no longer becomes distinct. Too much variants removes variety, because then nothing about them is unique.

[Kilvoctu]

Why? We need more varints I really don't see any duplicates so that can't be it. Why you're removing it to we barely have any variants

I skimmed through the changes yesterday and didn't really see anything I'm too heartbroken over personally. Most of the stuff is like, you don't even notice that you picked up a variant that is different from another variant.

The only thing that bums me out is that I really liked seeing all the smartphone cases during gameplay. These are items in which I'd read and appreciate each different one I pick up, like they're lore snippets or something. They're even typically accompanied by nice ASCII art.

[Bone-blood-moss]

Not really caring about the varints being removed besides pants and holy symbols but why not split it to pant color, then Pattern, then if it has an Image on the pants. We still have the Multiple variants that can change and also increase it. Another reason common rare items Get removed all the time.

[Holli-Git]

Not really caring about the varints being removed besides pants and holy symbols but why not split it to pant color, then Pattern, then if it has an Image on the pants. We still have the Multiple variants that can change and also increase it. Another reason common rare items Get removed all the time.

I don't follow what you're saying. Could you please rephrase it?