Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutations can have a custom activation message #77419

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Mutations can have a custom activation message #77419

merged 1 commit into from
Oct 30, 2024

Conversation

RenechCDDA
Copy link
Member

Summary

Features "Mutations can have a custom activation message"

Purpose of change

Requested by @Standing-Storm and @RedMisao

Seemed like a reasonable thing to add.

Describe the solution

Move the previous hardcoded message "You activate your %s." to become the new default

Load user-defined messages if they exist, otherwise fallback to the default

Dispense translations as needed

Describe alternatives you've considered

Removing the activation message entirely and just letting people use activation_eocs?

Testing

2024-10-28.22-24-31.mp4

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 29, 2024
@Maleclypse Maleclypse merged commit d9d7796 into CleverRaven:master Oct 30, 2024
22 of 28 checks passed
@RenechCDDA RenechCDDA deleted the custom_mutation_activation_msg branch October 30, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenechCDDA @Maleclypse