Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Goblins and dwarves can craft in the dark #76669

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[Magiclysm] Goblins and dwarves can craft in the dark"

Purpose of change

Dwarves and goblins in The World's Most Popular Roleplaying Game can see in complete darkness, and goblins are supposed to be nocturnal, so it makes sense to allow them to craft in the dark.

Describe the solution

Add a CRAFT_IN_DARKNESS flag that allows the bearer to ignore light levels when crafting.

It does not allow you read in the dark. That is deliberate.

Describe alternatives you've considered

Testing

Goblins and dwarves can craft in the dark. No one else can.

Additional context

They can't go completely without light because of reading, but I remember something I read in an old sourcebook about how dark elf wizards were the only dark elves who were used to light, because there was no way to get around having to study their spellbooks by lanternlight, and that stuck with me.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod labels Sep 26, 2024
@github-actions github-actions bot requested a review from KorGgenT September 26, 2024 02:52
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 26, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 26, 2024
@Maleclypse Maleclypse merged commit 5d38e0d into CleverRaven:master Sep 27, 2024
26 of 27 checks passed
@Standing-Storm Standing-Storm deleted the crafting-in-dark branch September 27, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants