Expand implementation of liquid ammo

[Fris0uman]

Summary

Features "Expand implementation of liquid ammo"

Purpose of change

Reimplement liquid attacks from #71964 using liquid ammo instead of spells

Describe the solution

• Make a bile sprayer gun
• Add relevant code to check armor layer if you hit a Character
• Add effects to ammo
• Add option to only apply effect if shot goes through armor
  - [x] Add option to only apply effect if a specific body part is touched
  - [ ] Instead of above option add a filter by bodypart type like sensor for exemple
• Apply effect to every touched parts
  - [ ] Make a dedicated liquid sound No need, soundpack can already set sounds per gun ids
• Make bile irritate skin if it touches skin
• Make bile make you smell more if it touches skin
• Make bile irritates eyes
• Make advanced bile (from evolved boomers) make you glow
• Advanced bile leave a glowing puddle
• Give gun to boomers
• Remove Hardcoded attack
• Consider reverting Add IRRITANT_IMMUNE to more armors and exoskeletons #77524 since armor has no reason to block skin irritation other than actually stoping the liquid going through
• Add documentation

Describe alternatives you've considered

Testing

2024-03-09.19-37-26.mp4

Additional context

Need #72169 merged first

This will probably make boomer attacks undodgeable, setting projectile speed to 1à instead of 1000 for liquid ammo doesn't seem to help from a quick test

[IdleSol]

Am I correct in understanding that this attack is similar to a rifle attack? So in one shot, an attack can only hit one body part?

[Fris0uman]

No, the point is to re-use the shotgun spread implementation

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[zachary-kaelan]

I noticed that a "bad scent attack" already exists in the form of the skunk_squirt spell:

{
  "id": "skunk_squirt",
  "type": "SPELL",
  "name": { "str": "Skunk Spray" },
  "description": "Skunk spray defense mechanism.",
  "valid_targets": [ "hostile" ],
  "effect": "attack",
  "shape": "cone",
  "min_range": 4,
  "max_range": 4,
  "//": "Duration is 3-5 hours, can't seem to write it in hours, had to write it in moves which is terrible",
  "min_duration": 1080000,
  "max_duration": 1800000,
  "flags": [ "RANDOM_DURATION" ],
  "effect_str": "skunk_spray"
}

Which applies its effects mostly using enchantments:

{
  "type": "effect_type",
  "id": "skunk_spray",
  "name": [ "Skunk Spray" ],
  "desc": [ "You were sprayed by a skunk!" ],
  "apply_message": "You're covered in a foul smelling fluid!",
  "rating": "bad",
  "max_duration": "5 hours",
  "base_mods": { "per_mod": [ -1 ], "int_mod": [ -1 ], "vomit_chance": [ 2000 ] },
  "enchantments": [
    {
  	  "values": [
  	    { "value": "SOCIAL_PERSUADE", "add": -10 },
  	    { "value": "SOCIAL_LIE", "add": -4 },
  	    { "value": "SOCIAL_INTIMIDATE", "add": 2 },
  	    { "value": "UGLINESS", "add": 5 },
  	    { "value": "SCENT_MASK", "add": 300 }
  	  ]
    }
  ]
}

I'm curious if any of this will be changed or if it will be considered a separate thing.

[kevingranade]

Everything looks reasonable so far, have you tried adding shot parameters and seeing if it does multi-hit as expected?

[zachary-kaelan]

This isn't urgent, but at some point we'll probably want a new set of automated test cases.