Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make piano easy-deconstructable and thus possible to move as an item #71111

Merged
merged 9 commits into from
Jan 21, 2024

Conversation

KittyTac
Copy link
Contributor

Summary

Balance "Pianos can be fast-deconstructed and thus be moved as an item"

Purpose of change

You can't really take a piano home if you find one, which I felt was weird since they, well, have a function if mostly a RP one.

Describe the solution

Make the piano easy-deconstructable, dropping it as an item. Then you can deconstruct the item to get what you would get if you deconstruct it before this PR. But you can also place it down.

Describe alternatives you've considered

Leaving as is.

Testing

image

image

image

Additional context

Prepare for more mild music-related PRs! Maybe I will make the huge speakers usable.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Appliance/Power Grid Anything to do with appliances and power grid Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 20, 2024
Copy link
Contributor

@Karol1223 Karol1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The piano is absolutely not an appliance. Don't put it in that file.

@KittyTac
Copy link
Contributor Author

KittyTac commented Jan 20, 2024

The piano is absolutely not an appliance. Don't put it in that file.

idk why I didn't think of putting it in the decorative furniture file. But done. It's about as interactive as the big mirror so that tracks.

@The-Anjelo-Guy
Copy link
Contributor

I really appreciate the content of this PR, these little details that no one cares about really transform the game. At least now I can carry a piano home! Good job. I hope this PR is approved and merged correctly.

@Maleclypse Maleclypse merged commit 6daf298 into CleverRaven:master Jan 21, 2024
24 checks passed
@KittyTac KittyTac deleted the piano branch January 22, 2024 09:47
@Montimorency
Copy link
Contributor

Aren't pianos supposed to be moved with special techniques or equipment? This could in principle be addressed by adding an internal stage/variant to the primary Deconstruct construction, targeting pianos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants