Skip to content

replaced --v flag with LogLevel enum config and implemented module-level logging #728 #757 #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhmerrill merged 7 commits into from
Apr 19, 2021
Merged

replaced --v flag with LogLevel enum config and implemented module-level logging #728 #757 #760

mhmerrill merged 7 commits into from
Apr 19, 2021

Conversation

@hokiegeek2
Copy link
Contributor

@hokiegeek2 hokiegeek2 commented Apr 14, 2021

This draft PR enhances logging configuration as follows:

  1. Replaces --v flag with --logLevel flag to enable a global DEBUG, INFO. WARN, ERROR, or CRITICAL logging level
  2. Enables module-level logging level setting (implemented in a subset of the modules)

If the design of (2) is cool, will rollout to rest of modules, remove --v flag, and remove no-arg Logger.init() function

This was linked to issues Apr 14, 2021
replace --v flag with --loglevel #757
Closed
Make server-side loggers individually configurable. #728
Closed
@glitch
Copy link
Collaborator

glitch commented Apr 15, 2021 •
edited
Loading

Finished initial review up to and including commit baa5017. Looks good!

@stress-tess
Copy link
Member

stress-tess commented Apr 15, 2021

This looks good to me!

mhmerrill
mhmerrill reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@mhmerrill mhmerrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good so far. I think we should add some examples of use to the PR.

@hokiegeek2
Copy link
Contributor Author

hokiegeek2 commented Apr 15, 2021

I think this is looking good so far. I think we should add some examples of use to the PR.

@mhmerrill Gotcha, cool, good point, I will add a few use cases and corresponding screenshots

@hokiegeek2
Copy link
Contributor Author

hokiegeek2 commented Apr 15, 2021

setting logLevel to INFO via the --logLevel=LogLevel.INFO leads to just INFO,WARN,ERROR,CRITICAL messages to be printed from all modules:

image

setting the global logging level at INFO and MsgProcessing to DEBUG results in targeted debug messages:

image

logging is strongly quieted if the global logging level is set to WARN, enabling focus on the MsgProcessing module:

image

@hokiegeek2 hokiegeek2 marked this pull request as ready for review April 16, 2021 13:15
mhmerrill
mhmerrill reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@mhmerrill mhmerrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. I'd like to get @bradcray or @ronawho to weigh in on this since it's a newer chapel feature we haven't really leaned into before.

ronawho
ronawho reviewed Apr 16, 2021
View reviewed changes
@mhmerrill mhmerrill self-requested a review April 19, 2021 14:05
mhmerrill
mhmerrill approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@mhmerrill mhmerrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mhmerrill mhmerrill merged commit 84910c1 into Bears-R-Us:master Apr 19, 2021
@hokiegeek2 hokiegeek2 deleted the logging_enhancements_728_757 branch May 20, 2021 15:21
stress-tess pushed a commit that referenced this pull request Jun 15, 2021
Minimum changes to pass current tests (1/2):
a543312 
- Updates logging statements to use logLevel instead of v (PR #760)
- Updates `check` to `check_table` (PR #792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR #774)
- Makes `unregister_strings_by_name` a staticmethod
@stress-tess stress-tess mentioned this pull request Jun 15, 2021
Closed
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 24, 2021
Minimum changes to pass current tests (1/2):
cb59972 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Minimum changes to pass current tests (2/2):

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR Bears-R-Us#666 string test ends_with failure
-PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 25, 2021
Minimum changes to pass current tests:
e5a0a57 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR Bears-R-Us#666 string test ends_with failure
-PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 28, 2021
Minimum changes to pass current tests:
909236e 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 28, 2021
Minimum changes to pass current tests:
c681d6c 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 29, 2021
Minimum changes to pass current tests:
aa9401f 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 30, 2021
Minimum changes to pass current tests:
fbccae9 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Minimum changes to pass current tests:
4df6bd4 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Reapplies original minimum changes to get up-to-date with master and …
0ab5a1f 
…pass tests from PR#627:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
76e3df6 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
@stress-tess stress-tess mentioned this pull request Jul 1, 2021
Closed
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 7, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
5a9a848 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 9, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
1deecc5 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 14, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
f8bc457 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 20, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
e736559 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Aug 5, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
07f51d8 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Nov 22, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
9c9c431 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
@ronawho ronawho mentioned this pull request Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glitch glitch Awaiting requested review from glitch

@stress-tess stress-tess Awaiting requested review from stress-tess

2 more reviewers

@ronawho ronawho ronawho approved these changes

@mhmerrill mhmerrill mhmerrill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

replace --v flag with --loglevel Make server-side loggers individually configurable.

5 participants

@hokiegeek2 @glitch @stress-tess @ronawho @mhmerrill