Skip to content

Issue #761: Categorical, Strings, and pdarray registration updates #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhmerrill merged 1 commit into from
Apr 23, 2021
Merged

Issue #761: Categorical, Strings, and pdarray registration updates #774

mhmerrill merged 1 commit into from
Apr 23, 2021

Conversation

@glitch
Copy link
Collaborator

@glitch glitch commented Apr 22, 2021 •
edited
Loading

PR for Issue #761

Categorical.py
Added registration suite of functions to Categorical

  • register
  • is_registered
  • attach (static)
  • unregister
  • unregister_categorical_by_name (static)

Strings.py

  • Modifies Strings sub-component names to use '.' for extensions (i.e. abc.offsets and abc.bytes
  • Modifed Strings.is_registered to verify all parts are registered or unregistered
  • Adds static unregister_strings_by_name

pdarrayclass.py

  • Updates static method name unregister_pdarray_by_name
  • unregister_pdarray_by_name now only takes string argument

Updates to documentation
Additional unit tests for registration_test.py

NOTE: These changes were based on feedback from previous PR#768 and discussion regarding registration changes with @mhmerrill

@glitch glitch force-pushed the 761_register_categorical_squash branch from 3ad9a76 to d73442b Compare April 22, 2021 18:37
glitch
glitch commented Apr 22, 2021
View reviewed changes
stress-tess
stress-tess reviewed Apr 22, 2021
View reviewed changes
@stress-tess stress-tess self-requested a review April 23, 2021 16:36
mhmerrill
mhmerrill approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@mhmerrill mhmerrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

@mhmerrill
Copy link
Contributor

mhmerrill commented Apr 23, 2021

@glitch @pierce314159 I would like @glitch to fix the conflict with help from @pierce314159 ... then I will merge.

@glitch
Closes Bears-R-Us#761: Adding registration suite of functions for Cat…
0017a99 
…egorical

  This adds the following methods/functions to Categorical
    - register
    - is_registered
    - attach (static)
    - unregister
    - unregister_categorical_by_name (static)
  Unit tests were added to test and document various usage.
  Changes to other classes were also made to support Categorical registration.
    - pdarray
    - Strings

Issue Bears-R-Us#761: Adding doc string updates based on PR feedback.
@glitch glitch force-pushed the 761_register_categorical_squash branch from 5d55f4d to 0017a99 Compare April 23, 2021 17:01
@glitch
Copy link
Collaborator Author

glitch commented Apr 23, 2021

Resolved conflicts rebasing to HEAD of mhmerrill:master
Should be good to go pending CI checks.

@mhmerrill mhmerrill merged commit 68a4681 into Bears-R-Us:master Apr 23, 2021
@glitch glitch deleted the 761_register_categorical_squash branch April 26, 2021 13:17
stress-tess pushed a commit that referenced this pull request Jun 15, 2021
Minimum changes to pass current tests (1/2):
a543312 
- Updates logging statements to use logLevel instead of v (PR #760)
- Updates `check` to `check_table` (PR #792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR #774)
- Makes `unregister_strings_by_name` a staticmethod
@stress-tess stress-tess mentioned this pull request Jun 15, 2021
Closed
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 24, 2021
Minimum changes to pass current tests (1/2):
cb59972 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Minimum changes to pass current tests (2/2):

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR Bears-R-Us#666 string test ends_with failure
-PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 25, 2021
Minimum changes to pass current tests:
e5a0a57 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR Bears-R-Us#666 string test ends_with failure
-PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 28, 2021
Minimum changes to pass current tests:
909236e 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 28, 2021
Minimum changes to pass current tests:
c681d6c 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 29, 2021
Minimum changes to pass current tests:
aa9401f 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 30, 2021
Minimum changes to pass current tests:
fbccae9 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Minimum changes to pass current tests:
4df6bd4 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Reapplies original minimum changes to get up-to-date with master and …
0ab5a1f 
…pass tests from PR#627:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
76e3df6 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
@stress-tess stress-tess mentioned this pull request Jul 1, 2021
Closed
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 7, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
5a9a848 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 9, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
1deecc5 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 14, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
f8bc457 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 20, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
e736559 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Aug 5, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
07f51d8 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Nov 22, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
9c9c431 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stress-tess stress-tess stress-tess approved these changes

@hokiegeek2 hokiegeek2 Awaiting requested review from hokiegeek2

+1 more reviewer

@mhmerrill mhmerrill mhmerrill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glitch @mhmerrill @stress-tess