Skip to content

646 string test test ends with periodically fails #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reuster986 merged 4 commits into from
Feb 11, 2021
Merged

646 string test test ends with periodically fails #666

reuster986 merged 4 commits into from
Feb 11, 2021

Conversation

@hokiegeek2
Copy link
Contributor

@hokiegeek2 hokiegeek2 commented Feb 11, 2021

This PR contains the following:

  1. Fix Strings.endswith where a match is missed if the user-supplied delimiter matches the last character in the last string within the Strings object.
  2. Added corresponding test case for Strings.endswith fix
  3. Fixed broken gremlins-related tests in test_ends_with, test_peel, test_stick

reuster986
reuster986 reviewed Feb 11, 2021
View reviewed changes
src/SegmentedArray.chpl
// -1 for null byte
hits[oD.interior(-(oD.size-1))] = truth[oa[oD.interior(oD.size-1)] - substr.numBytes - 1];
hits[oD.high] = truth[D.high];
hits[oD.high] = truth[D.high-1];
Copy link
Collaborator

@reuster986 reuster986 Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hokiegeek2 Great catch!

reuster986
reuster986 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@reuster986 reuster986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! How appropriate that the PR that finally fixes this diabolical bug is number 666.

@reuster986 reuster986 merged commit 97c359f into Bears-R-Us:master Feb 11, 2021
@hokiegeek2 hokiegeek2 deleted the 646_string_test_test_ends_with_periodically_fails branch February 11, 2021 15:34
stress-tess pushed a commit that referenced this pull request Jun 15, 2021
Minimum changes to pass current tests (2/2):
6f8cbfe 
Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR #666 string test ends_with failure
-PR #781 off by one in SegmentedArray peel method
@stress-tess stress-tess mentioned this pull request Jun 15, 2021
Closed
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 24, 2021
Minimum changes to pass current tests (1/2):
cb59972 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Minimum changes to pass current tests (2/2):

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR Bears-R-Us#666 string test ends_with failure
-PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 25, 2021
Minimum changes to pass current tests:
e5a0a57 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
-PR Bears-R-Us#666 string test ends_with failure
-PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 28, 2021
Minimum changes to pass current tests:
909236e 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 28, 2021
Minimum changes to pass current tests:
c681d6c 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 29, 2021
Minimum changes to pass current tests:
aa9401f 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jun 30, 2021
Minimum changes to pass current tests:
fbccae9 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Minimum changes to pass current tests:
4df6bd4 
- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Reapplies original minimum changes to get up-to-date with master and …
0ab5a1f 
…pass tests from PR#627:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 1, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
76e3df6 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
@stress-tess stress-tess mentioned this pull request Jul 1, 2021
Closed
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 7, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
5a9a848 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 9, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
1deecc5 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 14, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
f8bc457 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Jul 20, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
e736559 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Aug 5, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
07f51d8 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
stress-tess pushed a commit to stress-tess/arkouda that referenced this pull request Nov 22, 2021
Reapplies original minimum changes to get PR Bears-R-Us#627 up-to-dat…
9c9c431 
…e with master and pass tests:

- Updates logging statements to use logLevel instead of v (PR Bears-R-Us#760)
- Updates `check` to `check_table` (PR Bears-R-Us#792)
- Removes outdated `Strings.attach` function which used `_` for subcomponents (new convention is `.` per PR Bears-R-Us#774)
- Makes `unregister_strings_by_name` a staticmethod

Manually applied recent changes to `SegmentedArray.chpl` because automatic merge was thrown off by addition of `class SegSArray` including:
- PR Bears-R-Us#666 string test ends_with failure
- PR Bears-R-Us#781 off by one in SegmentedArray peel method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reuster986 reuster986 reuster986 approved these changes

@mhmerrill mhmerrill Awaiting requested review from mhmerrill

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hokiegeek2 @reuster986