Add support for passing server args to runClient/run_benchmarks.py #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual server options were replaced in 650/760, so just update the start server wrapper args to reflect the name change.
Add `--server-args` argument to `runClient`/`run_benchmarks.py`. This allows passing arbitrary options to the server. While here, unify some of the options for these scripts (support both version of num locales, add port to runClient.) Example usage: ``` ./benchmarks/run_benchmarks.py argsort --server-args=--CommAggregation.dstBuffSize=256 --server-args=--CommAggregation.srcBuffSize=12 ``` Resolves 1006
glitch
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--server-argsargument torunClient/run_benchmarks.py. This allowspassing arbitrary options to the server. While here, unify some of the options
for these scripts (support both version of num locales, add port to runClient)
and change
start_arkouda_serverlog/verboseargs totrace. The actualserver options were replaced in #650/#760, so just update the start server
wrapper args to reflect the name change.
Example usage:
Resolves #1006