cleaned up verbosity message info #649 #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuster986
approved these changes
Feb 3, 2021
Collaborator
|
should be able to pull master now and pass CI |
…9_cleanup_verbosity_README_entry
…9_cleanup_verbosity_README_entry
mhmerrill
approved these changes
Feb 9, 2021
README.md
Outdated
|
|
||
| Memory tracking is turned on by default and turned off by using the `--memTrack=false` flag | ||
|
|
||
| Logging messages are turned on by default and turned off by using the `--logging=false` flag |
Contributor
There was a problem hiding this comment.
As we have discussed and I think we are all agreed to change/rename the --logging flag to --trace. I would like you to make this change as part of this PR. I would also like the text here to be changed to say we are putting out a trace of the server operations (cmd, timing, and memory usage).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.