Export animations only, fixes for glTF and Maya exporter using MEL #702

noalak · 2019-12-03T13:07:21Z

This PR is resolving issues:

Revamp the exporter UIs and add the missing requested export flags support #537 (linked to Animation Export only feature. #525) : Export animations only (linked to PR Add option to import animations only Babylon.js#7252 for import)
Expose Maya exporter to MEL commands #599 : Expose Maya exporter to MEL commands (see Maya/MELScripts/exportScriptExemple.mel)
Maya glTF exporter writes unnecessary default values #626 : glTF default values
Maya glTF exporter writes out duplicate texture objects #627 : Duplicate glTF texture objects

Disclaimer:
The 'export animations only' feature is implemented for 3ds Max.
@Drigax, @elpie89, @Selmar are invited to test the export and import process. Samples are provided in the exporter AnimationsOnly samples folder or can be downloaded via WeTransfer here.
Once conclusive, we will implement the solution for Maya as well.

…SimultaneousLights, unlit) Add connection to log prints

Add KHR_materials_unlit checkbox

Fix base color and metallic roughness textures names when exporting a standard material to glTF

Fix diffuse and alpha textures merging when alpha is read from RGB

Add Node editor (NE) templates Update Attribute editor (AE) templates

Export alphaCutOff attribute for Masked StingrayPBS material only Export merged color texture for Masked StingrayPBS material Fix default color initialisation when merging textures

Add log level

Export babylon material attributes

# Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.Material.cs # SharedProjects/Babylon2GLTF/GLTFExporter.Material.cs

# Conflicts: # Maya/Forms/ExporterForm.Designer.cs

…eras, mesh and materials

# Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.Mesh.cs # Maya/Exporter/BabylonExporter.Material.cs # SharedProjects/Babylon2GLTF/GLTFExporter.Material.cs # SharedProjects/BabylonExport.Entities/BabylonMaterial.cs # SharedProjects/BabylonExport.Entities/BabylonMesh.cs

Clean up code

# Resolved Conflicts: # 3ds Max/Max2Babylon/Forms/ExporterForm.cs # BabylonJS_Installer/BabylonJS_Installer/BabylonJS_Installer.csproj # BabylonJS_Installer/BabylonJS_Installer/Downloader.cs # BabylonJS_Installer/BabylonJS_Installer/MainForm.Designer.cs

noalak · 2019-12-03T14:33:20Z

Next are TECHNICAL notes on the export animation only feature.

The implementation of this feature has been discussed in this issue and this PR and other nested threads.
The user is responsible of node's name uniqueness (1st solution chosen).

The feature is mostly handled during Babylon export. The babylon to glTF part has been changed only to handle backdoor properties like animations of target cameras or lights.
Simple animations and group animations are both handled just as before (minimal changes, mostly fixes for unusual cases).

Regarding exported data when exporting only animations:

meshes, lights and cameras are exported as nodes (=dummies)
the nodes exported are only the relevant ones: either animated nodes or their parent
this mean that non-animated nodes on leaves are not exported
non-animated intermediate nodes need to be exported as they are required by the glTF loader of babylon
materials and other global or custom parameters are not exported

Regarding implementation:

skeletons are not exported (a skeleton is a link between a mesh and a set of bones and will not vary between animations)
bones are exported (they are the animated dummies)
meshes are exported as dummies immediately to avoid a pass on useless features (mostly geometry)
cameras and lights are first exported completely, then their transform and animations get fixed and finally they are converted back to simple nodes. The time required to completely export a camera or light is minimal anyway.

Selmar · 2019-12-05T10:44:28Z

I don't think it's a surprise, but since you have chosen the path of unique names, we will most likely keep our own implementation on our side and won't be using this for our pipeline.

Drigax · 2019-12-09T21:07:17Z

@noalak the larger the PR, the harder it is to review and test. Can we please address a single issue for each PR moving forward? Especially in cases like this where the issues aren't related at all

Drigax · 2019-12-09T21:12:39Z

3ds Max/Max2Babylon/Exporter/BabylonExporter.cs

-        private BabylonNode exportNodeRec(IIGameNode maxGameNode, BabylonScene babylonScene, IIGameScene maxGameScene)
-        {
-            BabylonNode babylonNode = null;
+using Autodesk.Max;


Why is the whitespace changed in this file?

Drigax

Changes look good for the most part, I'm just concerned about the whitespace damaging our file history. :)

Drigax · 2019-12-10T17:05:22Z

Also, the whitespace changes are blocking the auto-merge

# Resolved Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.cs # 3ds Max/Max2Babylon/Forms/ExporterForm.cs

noalak · 2019-12-11T15:48:45Z

Whitespace fixed.

noalak · 2019-12-11T15:50:07Z

We will definitely make a PR for each feature in the future.
For documentation, do you want a single PR or several ones ?

3ds Max/Max2Babylon/Forms/ExporterForm.cs

Drigax · 2019-12-11T22:18:21Z

@noalak , for the documentation, a single PR should be sufficient for the exporter UI changes

Remove unused variable # Resolved Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.Mesh.cs

noalak and others added 30 commits September 24, 2019 10:50

Update layout definition system

abe36a8

Fix log window size

43f564b

Update auto generated layout system

ac63a5c

Fix log window size in exporter form

f971f38

Export Babylon attributes for standard material (backfaceCulling, max…

1673b2b

…SimultaneousLights, unlit) Add connection to log prints

Add default babylon attributes automatically at runtime

6b9f4a5

Add KHR_materials_unlit checkbox

Fix Transparency mode when exporting a standard material to glTF

a66695a

Fix base color and metallic roughness textures names when exporting a standard material to glTF

Add a babylon material node to hold all attributes

ac1f666

Fix diffuse and alpha textures merging when alpha is read from RGB

Ignore babylon transparency mode value when exporting

8c8d0bb

Add Node editor (NE) templates Update Attribute editor (AE) templates

Export _unlit attribute for PBRMetallicRoughnessMaterial

370dd06

Export alphaCutOff attribute for Masked StingrayPBS material only Export merged color texture for Masked StingrayPBS material Fix default color initialisation when merging textures

Add sample files

ef07d21

Merge branch 'master' of https://github.com/BabylonJS/Exporters

3f4245e

Merge branch 'master' of https://github.com/BabylonJS/Exporters

9e2415e

Move log feature to dedicated internal class

a784778

Add log level

Fix transparencyMode and alpha for Standard and Arnold materials

969332a

Add babylon material attributes to native materials

00f871e

Export babylon material attributes

Merge branch 'master' of https://github.com/BabylonJS/Exporters

4edb78e

Get arnold material opacity from dedicated attributes

afa27b1

Add samples for babylon material attributes attached to native materials

479ae76

Merge branch 'master' of https://github.com/BabylonJS/Exporters

71670a4

# Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.Material.cs # SharedProjects/Babylon2GLTF/GLTFExporter.Material.cs

Set an unique ID for babylon attributes of an Arnold material

09bb30b

//Add the user custom attributes to metadata

4a18fe7

Merge branch 'master' of https://github.com/BabylonJS/Exporters

134ed0e

Merge branch 'master' of https://github.com/Bloadrick/Exporters

0879c9f

# Conflicts: # Maya/Forms/ExporterForm.Designer.cs

// add custom user attributes in babylon and gltf for the lights, cam…

b4f02cc

…eras, mesh and materials

Merge branch 'master' of https://github.com/BabylonJS/Exporters

0ebc347

Export custom attributes from nodes and materials

2ce94fd

Do not export null CustomAttributes

d97f7e0

Add samples for custom attributes

f47162d

noalak added 6 commits December 2, 2019 17:41

Merge branch 'master' of https://github.com/Bloadrick/Exporters

7c90915

Fix animated node export

a7d7e66

Clean up code

Fix to export target camera and target light animations

08102c6

Add samples files for animation only feature

5c1d672

Merge branch 'master' of https://github.com/BabylonJS/Exporters

ca4805d

noalak mentioned this pull request Dec 3, 2019

Add option to import animations only BabylonJS/Babylon.js#7252

Merged

Drigax reviewed Dec 9, 2019

View reviewed changes

Drigax suggested changes Dec 9, 2019

View reviewed changes

noalak added 6 commits December 11, 2019 16:19

Format file

eaa00c0

Merge branch 'master' of https://github.com/BabylonJS/Exporters

fa3794f

# Resolved Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.cs # 3ds Max/Max2Babylon/Forms/ExporterForm.cs

Format

28f2f53

Revert

f0efd54

Revert copy/paste file

e3da27c

Reapply changes

577ebee

Drigax suggested changes Dec 11, 2019

View reviewed changes

3ds Max/Max2Babylon/Forms/ExporterForm.cs Outdated Show resolved Hide resolved

noalak added 3 commits December 12, 2019 08:45

Copy/Paste ExporterForm from BabylonJSRepo

8a070b4

Reapply changes

fc7a6b3

Merge branch 'master' of https://github.com/BabylonJS/Exporters

8561e22

Remove unused variable # Resolved Conflicts: # 3ds Max/Max2Babylon/Exporter/BabylonExporter.Mesh.cs

Drigax approved these changes Dec 12, 2019

View reviewed changes

Drigax merged commit eb05256 into BabylonJS:master Dec 12, 2019

Drigax mentioned this pull request Dec 12, 2019

Export only anim extension #691

Closed

noalak mentioned this pull request Dec 19, 2019

Export animations only for Maya #723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export animations only, fixes for glTF and Maya exporter using MEL #702

Export animations only, fixes for glTF and Maya exporter using MEL #702

noalak commented Dec 3, 2019 •

edited

Loading

noalak commented Dec 3, 2019 •

edited

Loading

Selmar commented Dec 5, 2019

Drigax commented Dec 9, 2019

Drigax Dec 9, 2019 •

edited

Loading

Drigax left a comment

Drigax commented Dec 10, 2019

noalak commented Dec 11, 2019

noalak commented Dec 11, 2019

Drigax commented Dec 11, 2019

Export animations only, fixes for glTF and Maya exporter using MEL #702

Export animations only, fixes for glTF and Maya exporter using MEL #702

Conversation

noalak commented Dec 3, 2019 • edited Loading

noalak commented Dec 3, 2019 • edited Loading

Selmar commented Dec 5, 2019

Drigax commented Dec 9, 2019

Drigax Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

Drigax left a comment

Choose a reason for hiding this comment

Drigax commented Dec 10, 2019

noalak commented Dec 11, 2019

noalak commented Dec 11, 2019

Drigax commented Dec 11, 2019

noalak commented Dec 3, 2019 •

edited

Loading

noalak commented Dec 3, 2019 •

edited

Loading

Drigax Dec 9, 2019 •

edited

Loading