-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to import animations only #7252
Conversation
Update sandbox js and html to include these additions
…on file Add Import animations button in Inspector Update icon in sandbox Beautify code
Next are TECHNICAL notes. USE CASESThe import animation button in bottom menu of the sandbox will perform 2 operations:
The import animation button in the inspector will only load animations. There are not callbacks available by the sandbox. The use cases are expected to be:
EDIT: No import animation button in bottom menu of the sandbox. A callback will be added when animation merge is complete. CONSECUTIVE LOADS OF ANIMATIONSThe simple animations are always discarded between 2 consecutive loads of animation files. The group animations are appended between 2 consecutive loads of animation files. An animation group with same name as one previously loaded will override the previous one. Note that from the 3dsMax and Maya exporters, all animations are exported in glTF as group animations, even the simpliest ones. EDIT: Add an option to choose between 'append' and 'overwrite' modes. |
So overall:
|
Remove extras assignment from glTF lights (extension) Clean up code to reflect overwrite mode only Update animatable target equality check
Add option to handle animation groups consecutive loads
Beautify code
You must run npm run build anyway to make sure the PR is correct :) That will update the d.ts for you but yeah please ignore the dist files for the PR itself |
…onsTo Clean up unused stuff Other minor changes
Well! now you need to check why the CI is failing :D |
Revert formating
Revert formating
Revert formating
I still need to build successfully on my PC :) |
Good luck ;D |
Build -> successful! |
Yeah Congrats!!! Do you mind updating the doc and provide some examples files for the doc? |
Sure |
This PR is resolving issue BabylonJS/Exporters#537 (linked to BabylonJS/Exporters#525).
This is the import part of the process. See PR BabylonJS/Exporters#702 for the export part.
@Drigax, @elpie89, @Selmar are invited to test the export and import process. Samples are provided in the exporter AnimationsOnly samples folder or can be downloaded via WeTransfer here.
The idea is to first load a scene file and then any animation file.
The node names and hierarchy must be identical to be able to link animation and scene files.
You can import animation files through: