[AutoPR @azure/arm-peering] Peering api 2021-06-01 #4970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
26 tasks
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14703/@azure_arm-peering
branch
4 times, most recently
from
8dd3235
to
e7c48f0
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14703/@azure_arm-peering
branch
2 times, most recently
from
224925a
to
75f8d8f
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14703/@azure_arm-peering
branch
from
75f8d8f
to
b6ec42c
Compare
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Always use x-ms-date for Hmac * Try to fix phone number tests * Still another error in phone number tests * Update phoneNumber session records * Update phone numbers node sessions * Manually fix node record sessions for phone numbers * Update missed session files Co-authored-by: JP Chen <jiach@microsoft.com>
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14703/@azure_arm-peering
branch
2 times, most recently
from
0e83f73
to
31f026c
Compare
This PR makes three changes to our deployment template: - Add networkAcls to the Managed HSM properties - Remove the 60 second sleep after activation - Speed up challenge auth tests for KV Keys by using methods that don't require creating and deleting keys. The first is now needed, and without it deployment will fail. The second is no longer needed, since it looks like the az cli appropriately waits before coming back. Finally, the third is something I noticed - there's no reason to create and purge keys which takes a long time in order to test CAE.
## What - Bump @opentelemetry/api to 0.20.0 in @azure/core-tracing - Move all packages that are on core-http to the next core-tracing version - Remove version collision check from the tracer cache ## Why This is part of our effort to move everyone to OTel 0.20.0 - but we have to stage it due to a transitive dependency and a breaking change in OTel. This PR updates core-tracing to use the latest OTel, fixes any breaking changes, and moves packages that we can move to the latest version of core-tracing. Once core-rest-pipeline 1.1.0 is GA'd we'll be able to move the rest of the packages over to the latest core-tracing as well. Removing the version collision came out of an offline discussion after these changes were reviewed - since it's a common source of pain and hasn't added much benefit (tracer conflicts incompatibility was never a problem) we decided to remove that logic and always grab a unique symbol per OT compatibility. ## Callouts The packages that are already on core-v2 will _not_ be upgraded at this time - we'll coordinate that with the GA of core-rest-pipeline 1.1.0
…-persistence (Azure#15384) * [identity] Remove machine-code-dependent codepaths (Azure#15024) * [identityg Remove machine-code-dependent codepaths * Linter fixes * Disable broken perf test * Added missing import back * [identity] Add extension registration API and default credential stack * [identity-native] Introducing identity-native * [identity] Rework extension API. * Remove identity native * Identity-persistence module * Adding identity-vscode module * Updated rush configuration * Moved identity perf back to linking local identity * Symbolic refactor of extension system * Renamed MsalCredentialOptions to CacheableCredentialOptions * Use Symbol.for instead of hacking around SymbolConstructor * Improved identity-vscode samples * Use persistence by default if a persistence provider has been registered. * Improved identity-persistence samples * Rename to identity-cache-persistence * Feedback from arch board for mainline identity package * Rename CredentialPersistenceOptions, format and lint * Revert sanitization of scopes. * Regenerated API.md for mainline identity * Add tests and finalize @azure/identity-cache-persistence * Record tests for identity-cache-persistence * Renamed sample files. * Some changes for testing in identity * Updated identity-vscode * Remove async version of useIdentityExtension * Added a couple of tests for default no-extension behavior * Fixed tests in recorder * Removed errant console.log * Added basic tests of identity-vscode * Fixed a couple of tests that have started caching correctly * Added browser shim for extensions/consumer.ts * Mock keytar using sinon in live/playback environments * Disable persistence tests on node !== 12 * Addressed feedback in identity-cache-persistence * Restore perf-test * Removed sanitizeScopeUrl from recorder * Update sdk/identity/identity/src/credentials/visualStudioCodeCredential.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Fix gitignores * Feedback for identity-vscode * Changelog entry for recorder changes. * core-http -> core-auth * setter methods instead of setter props * Some changes to docs and keywords * Fixed linter warning * Switch persistence tests from 12 to 14. * Make the tests even refuse to import msal-node-extensions on anything other than Node 14 * Reverted changes to recorder * master -> main * More master -> main * [identity] Make the samples extract only part of the token data Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
…5850) * Adding support for temporary redirect * Lint
* Changes to create artifact in package directory
… fixing flaky tests to be more reliable. (Azure#15761) Making changes to simplify a flaky test (and hopefully make it more reliable). The main issue with the 'handle interrupted detach' method was that it relied on too many moving parts to work reliably. We could just eternally loop like we'd expect customers to do, but in the end we have a very simple test we're trying to perform - we want to receive, and while we're in the process of draining, cause a detach and have it early exit and reject/resolve immediately rather than waiting for the timeout. I reworked the test to make that simpler by just removing the unneeded connection.idle() and just calling directly into the onDetached method. Because it happens prior to rhea even seeing that we're draining we should reliably win that race each time. There were a couple of other things changed for this PR as well: - The max time per test was lowered accidentally. Bringing it back what's been used as the standard time in other libraries - Fixed a spot in receiveMessages() where, if the link had been closed, we'd falsly return an empty array instead of throwing an exception indicating the link closed. This didn't appear to be related to the bug but it's incorrect and can hide bugs so I'd rather just throw the error than eat the condition and return an empty array. It's rare, but when it does happen the empty array response isn't right either - we're probably in the middle of a connection reset/change event. Fixes Azure#13461
* Update links with master to use main * Update ci.yml files Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Update pipeline generation tool version Consume latest changes from pipeline generation tool in Azure/azure-sdk-tools#1708 * Update tool version to include fix for public ci Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
…ll anymore (Azure#15783) I’ve got some customers writing to me directly with some confusion regarding getToken returning null. We’ve got some remnants of this type, but at this point, Identity doesn’t return null (except for ClientSecretCredential in the browser, which is generally unusable outside of our tests). This PR is to update these docs and to give a bit of clarity on what errors we’re throwing.
…ure#15883) Now that `@opentelemetry/api` GA'd at [1.0.0](https://www.npmjs.com/package/@opentelemetry/api) we can bump our own dependency to `@opentelemetry/api@1.0.0` Reminder: not _all_ packages are on the latest @opentelemetry/api... those that depend on @azure/core-rest-pipeline cannot be upgraded yet.
This should allow our pipelines to pick these packages up for publication.
## What - Update core-http to 2.0.0 - Update core-lro to 2.0.0 - Update packages to use latest version ## Why This will support our last breaking change for core-tracing, and allow everyone to be on the same minimum version. This will also allow us to target ES2017 across the board.
…e#15031) In this PR we're aligning the samples of Identity with other languages. The samples I'm adding in this PR are: - Rolling certificates with ClientCertificateCredential ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/ClientCertificateCredentialSamples.md#rolling-certificates)). - ClientCertificateCredential with a Key Vault Certificate ([Python](Azure/azure-sdk-for-python#18109)) (decided not to use `@azure/keyvault-certificates` because of the possible issues converting certificates from one format to another in Node). - Custom credentials ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#defining-custom-credential-types)). - Using MSAL directly ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-msal-directly)). - On Behalf Of Flow ([.Net](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-the-on-behalf-of-flow)). New samples related to the v2-specific features will be added after the Identity package is separated. Related to Azure#14435 --- I’ve decided to use this opportunity to: Fix Azure#15324 This PR also implicitly: Fixes Azure#15573
This greatly improved my first open experience on my laptop. The only tradeoff is `node_modules` folders won't appear in the file tree of VS Code, but I think this is a pretty uncommon place to browse into manually.
Co-authored-by: Praveen Kuttappan <praveen.kuttappan@gmail.com>
* displayed links as a list rather than a single line * displayed links as a list rather than a single line * appconfiguration\Readme: displayed links as a list rather than a single line * attestation\Readme: displayed links as a list rather than a single line #6449 * Apply suggestions from code review Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Adds the list test Closes Azure#13981
Fixes Azure#15796 ## Problem The throttlingRetryPolicy in core-http has the potential to retry for an extended period if the service continues returning "retry after" headers on subsequent calls. Here's the snippet of code that handles the "retry after" retries: ```typescript public async sendRequest(httpRequest: WebResource): Promise<HttpOperationResponse> { return this._nextPolicy.sendRequest(httpRequest.clone()).catch((err) => { // other code elided.... return delay(delayInMs).then((_: any) => this.sendRequest(httpRequest.clone())); ``` ## Solution Update delay such that it respects abort signal. Similar to what I had to do for app-config at Azure#15721
Followed the steps at https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide /cc @willmtemple Note: I moved browserSamples and expressSamples into the generated v5 samples folder since dev-tool doesn't work with those.
to delete tags before delete the image as this is the recommended best practice for the service.
* [Identity] Test improvements * temporary node 16 fix * Since unhandled promise rejections are not supported in Node 16, tickAsync can't be awaited * fix the test Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
## What - Regenerate from 7.3-preview swagger - Add `getRandomBytes` method ## Why - For July we would like to add support for the RNG endpoint in a Managed HSM. While this is a customer ask for Java, we will add this to all languages at the same time.
As part of #7022, we will be moving the version of `@types/node` from 8 to 12 This PR has the changes required to fix the build errors that occurred when trying out this change - The [Agent](https://nodejs.org/docs/latest-v12.x/api/http.html#http_class_http_agent) class in Node.js 12 has an extra property `maxTotalSockets`. The docs say there is a default value for this, but it it is still marked as a mandatory property in the types. We use our own interface for this class for the purposes of user providing their own custom agent. Am casting it in this PR to the expected type. If anyone has better ideas here, am all ears :) - `global.URL` is not a thing as per the types for Node.js 12. We needed this to support Node.js 8 - Fixing the types for `port` in the parsed url The actual move to v12 for `@types/node` will be done in a separate PR
* Use BufferEncoding as encoding is not a string in Node.js 12 * Fix typing issue for fsStat returning unknown
* adds simple background refresh * Adds setInterval with unref * cleanup * wip prenock * wip * Removes recorder, fixes timeout in tests * extract api * fix lint * format * Adds flag * lint * Fix parition spelling * modify endpoint check * fix tests * Comment proxy * adds back copyright * skip session spec * Fix session token * Fix session spec on emulator
* Support track2 management packages
Perf test packages should not be using the eslint plugin
Fixes the below error
```
ESLint couldn't find the plugin "@azure/eslint-plugin-azure-sdk".
(The package "@azure/eslint-plugin-azure-sdk" was not found when loaded as a Node module from the directory "/home/vsts/work/1/s/sdk".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install @azure/eslint-plugin-azure-sdk@latest --save-dev
The plugin "@azure/eslint-plugin-azure-sdk" was referenced from the config file in "../../../.eslintrc.json".
```
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14703/@azure_arm-peering
branch
from
31f026c
to
d05624d
Compare
Merge 1f145a5e9d39d6670f94ccfc5af26d4339029459 into e793a8cd4b8d8b6b21cc7a26e364ad56d23a4861
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14703/@azure_arm-peering
branch
from
d05624d
to
4eeb41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#14703
Installation Instructions
You can install the package
@azure/arm-peeringof this PR using the following command:curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14703/azure-sdk-for-js/@azure_arm-peering/azure-arm-peering-1.0.0.tgz" -o azure-arm-peering-1.0.0.tgz npm install azure-arm-peering-1.0.0.tgzDirect Download
The generated package can be directly downloaded from here: