Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint script for app config perf test #16046

Merged
1 commit merged into from
Jun 28, 2021

Conversation

ramya-rao-a
Copy link
Contributor

Perf test packages should not be using the eslint plugin

Fixes the below error



ESLint couldn't find the plugin "@azure/eslint-plugin-azure-sdk".

(The package "@azure/eslint-plugin-azure-sdk" was not found when loaded as a Node module from the directory "/home/vsts/work/1/s/sdk".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @azure/eslint-plugin-azure-sdk@latest --save-dev

The plugin "@azure/eslint-plugin-azure-sdk" was referenced from the config file in "../../../.eslintrc.json".

@ghost ghost added the App Configuration Azure.ApplicationModel.Configuration label Jun 28, 2021
@ghost
Copy link

ghost commented Jun 28, 2021

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit facf5c1 into Azure:main Jun 28, 2021
ghost pushed a commit that referenced this pull request Jun 28, 2021
Follow up for #16046 to fix the resulting linter errors
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants