[KeyVault] - Add networkAcls to MHSM ARM template #15830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run js - keyvault-admin - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - keyvault-admin - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - keyvault-keys - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sadasant
approved these changes
Jun 18, 2021
|
/check-enforcer override Explanation: there is a known issue that is being investigated on the service side. But, the changes I made here have been validated to deploy a managed HSM successfully. I'd rather merge this in now and monitor the pipeline since it actually deploys resources correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes to our deployment template:
The first is now needed, and without it deployment will fail.
The second is no longer needed, since it looks like the az cli appropriately waits before coming back.
Finally, the third is something I noticed - there's no reason to create and purge keys which takes a long time in order to test CAE.