Prepare Storage packages to move to @types/node v12 #16020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ramya-rao-a
changed the title
ramya-rao-a
requested review from
EmmaZhu,
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
|
cc @xirzec |
ramya-rao-a
force-pushed
the
storage-node12
branch
from
659939d
to
3d93d49
Compare
EmmaZhu
approved these changes
Jun 28, 2021
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #7022, we will be moving the version of
@types/nodefrom 8 to 12This PR has the changes required to fix the build errors that occurred in the Storage packages when trying out this change.
The net changes are:
encodinginBuffer.from(string, encoding)overload is not a string, but a union of string literals calledBufferEncodingin Node.js 12 & abovefs.stat()returnsPromise<unknown>for non node case. Updated to ignore the case when isNode is false as the entire file is only used in node due to there being a separate utils file for the browser