Start Azure SDK log forwarder in AzMon OTel distro #42374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
azmondistro-log-forwarder
branch
from
70d3787
to
a8fd665
Compare
...monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Vendoring/AzureEventSourceLogForwarder.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Vendoring/AzureEventSourceLogForwarder.cs
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
lmolkova
requested review from
cijothomas,
reyang,
rajkumar-rangaraj,
vishweshbankwar and
jsquire
as code owners
...onitor.OpenTelemetry.AspNetCore/src/Internals/AzureSdkCompat/AzureEventSourceLogForwarder.cs
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs
Outdated
Show resolved
Hide resolved
...emetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/AzureSdkLoggingTests.cs
Show resolved
Hide resolved
...onitor.OpenTelemetry.AspNetCore/src/Internals/AzureSdkCompat/AzureEventSourceLogForwarder.cs
Show resolved
Hide resolved
...emetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/AzureSdkLoggingTests.cs
Show resolved
Hide resolved
|
Can you please add an entry in the changelog? |
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Mar 5, 2024
jsquire
requested changes
Mar 5, 2024
sdk/extensions/Microsoft.Extensions.Azure/src/AzureEventSourceLogForwarder.cs
Outdated
Show resolved
Hide resolved
sdk/extensions/Microsoft.Extensions.Azure/src/Internal/EventSourceEvent.cs
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
azmondistro-log-forwarder
branch
from
b0c34c5
to
cf7b171
Compare
|
@annelo-msft @christothes @JoshLove-msft could you please take a look at the core changes? |
christothes
reviewed
Mar 6, 2024
christothes
approved these changes
Mar 6, 2024
jsquire
approved these changes
Mar 6, 2024
...tor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Azure.Monitor.OpenTelemetry.AspNetCore.csproj
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Mar 6, 2024
annelo-msft
approved these changes
Mar 6, 2024
:( |
lmolkova
added a commit
to lmolkova/docs
that referenced
this pull request
Mar 6, 2024
Updates Azure SDK .NET logging article according to Azure/azure-sdk-for-net#42374
lmolkova
added a commit
that referenced
this pull request
Mar 6, 2024
…#42476) * Follow-up: update AzMonDistro readme what's included - logs * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md Co-authored-by: Timothy Mothra <tilee@microsoft.com> --------- Co-authored-by: Timothy Mothra <tilee@microsoft.com>
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Start Azure SDK log forwarder in AzMon OTel distro
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
…#42476) * Follow-up: update AzMonDistro readme what's included - logs * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md Co-authored-by: Timothy Mothra <tilee@microsoft.com> --------- Co-authored-by: Timothy Mothra <tilee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41373
Adds slightly modified
AzureEventSourceLogForwarderto AzMon OTel Distro.Distro registers and starts log forwarder in case the original one from
Microsoft.Azure.Extensionswas not added.Reasons to not take dependency on
Microsoft.Azure.Extensions: