Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging with Azure.Monitor.OpenTelemetry.AspNetCore section #39854

Merged
merged 6 commits into from
Apr 1, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Mar 6, 2024

Updates Azure SDK .NET logging article according to Azure/azure-sdk-for-net#42374

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/azure/sdk/logging.md Logging with the Azure SDK for .NET

@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Mar 6, 2024
docs/azure/sdk/logging.md Outdated Show resolved Hide resolved
docs/azure/sdk/logging.md Outdated Show resolved Hide resolved
docs/azure/sdk/logging.md Outdated Show resolved Hide resolved
docs/azure/sdk/logging.md Outdated Show resolved Hide resolved
lmolkova and others added 2 commits March 6, 2024 14:23
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Christopher Scott <chriscott@hotmail.com>
@lmolkova
Copy link
Contributor Author

lmolkova commented Apr 1, 2024

@gewarren @BillWagner is there something blocking this PR from being merged?

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to squash and merge when you're ready. It looks like neither Bill nor I were tagged for review which is why we missed it.

docs/azure/sdk/logging.md Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@lmolkova
Copy link
Contributor Author

lmolkova commented Apr 1, 2024

@gewarren thanks a lot for taking a look, I don't have permissions to merge. Could you please hit the button? Thanks!

@gewarren gewarren merged commit d46e8c5 into dotnet:main Apr 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-azure/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants