Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureMonitorDistro] Conditionally skip failing tests #44423

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Jun 6, 2024

Our unit tests have been timing out.
I traced the root cause to #42374
The tests in AzureSdkLoggingTests fail only on MacOS & NET60.

Changes

  • introduce XUnit helper attribute to conditionally disable tests based on OS. This will be helpful as we've had similar issues with other tests.
  • Skip the affected tests only on MacOS & NET60

image

@github-actions github-actions bot added Monitor - Distro Monitor OpenTelemetry Distro Monitor - Exporter Monitor OpenTelemetry Exporter labels Jun 6, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra TimothyMothra changed the title Tilee/202406 investigate tests [AzureMonitorDistro] Conditionally skip failing tests Jun 6, 2024
@TimothyMothra TimothyMothra marked this pull request as ready for review June 6, 2024 22:13
@TimothyMothra TimothyMothra enabled auto-merge (squash) June 6, 2024 22:36
@TimothyMothra TimothyMothra merged commit 05dccb3 into main Jun 6, 2024
27 checks passed
@TimothyMothra TimothyMothra deleted the tilee/202406_investigate_tests branch June 6, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Distro Monitor OpenTelemetry Distro Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants