-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQ] Enable AzureSdkLogForwarder in Azure Monitor OTel distro #41373
Comments
Should this be an opt-in feature? |
Cijo commented that this sounds like the same feature that was added to the AI SDK:
Long term, is there a plan for Azure SDKs to migrate to ILogger natively? |
No, we won't add a dependency on ILogger and we will keep using EventSource to write our logs.
Users enable error/warn SDK logs by default because these logs provide observability. Some users enable info logs, some use them instead of traces - these logs are for users. Opt-in mechanism is already part of ILogger, but the distro should allow opt-in to happen. |
+1, the user should still be able to control their own log level/ sampling. The ask is for the capability for logging to wired up by default |
Library name
Azure.Monitor.OpenTelemetry.AspNetCore
Please describe the feature.
Azure SDKs emit logs using EventSources. EventSources can be forwarded to ILogger using AzureEventSourceLogForwarder
Some SDKs like CosmosDB leverage this to emit essential diagnostic information and currently have to ask users to enable it explicitly:
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/8af055c68e01af1df9d530d3b716437c68ee5579/Microsoft.Azure.Cosmos.Samples/Usage/OpenTelemetry/Program.cs#L67-L68
AzMon distro should support Azure SDK logs by default.
The text was updated successfully, but these errors were encountered: