Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-rest-pipeline] Make FetchClient the default browser httpclient #19859

Closed
20 of 23 tasks
joheredi opened this issue Jan 14, 2022 · 0 comments
Closed
20 of 23 tasks

[core-rest-pipeline] Make FetchClient the default browser httpclient #19859

joheredi opened this issue Jan 14, 2022 · 0 comments
Assignees
Milestone

Comments

@joheredi
Copy link
Member

joheredi commented Jan 14, 2022

Currently, we are blocked on this by Playback tests as the recorder is tightly coupled with xhr. Once the SDKs that depend on CoreV2 are migrated to the new recorder we should be able to make the switch. This is a list of the SDKs that need to be migrated:

@joheredi

@timovv

  • ./sdk/containerregistry/container-registry/package.json (Pipeline = client["client"].pipeline)
  • ./sdk/textanalytics/ai-text-analytics/package.json (client["client"].pipeline)
  • ./sdk/iot/iot-modelsrepository/package.json (no recorder - remove dependency): [iot-modelsrepository] Remove unnecesary dependency on recorder #20150
  • ./sdk/videoanalyzer/video-analyzer-edge/package.json (no recorder - remove dependency): does not depend on recorder
  • ./sdk/remoterendering/mixed-reality-remote-rendering/package.json (client["client"].pipeline)

@JonathanCrd

@HarshaNalluru

Misc

/cc: @jeremymeng @HarshaNalluru @timovv @JonathanCrd

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 14, 2022
@joheredi joheredi self-assigned this Jan 14, 2022
@joheredi joheredi added this to the [2022] February milestone Jan 14, 2022
@joheredi joheredi added Azure.Core and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 14, 2022
@JonathanCrd JonathanCrd self-assigned this Feb 2, 2022
@HarshaNalluru HarshaNalluru self-assigned this Feb 4, 2022
timovv added a commit that referenced this issue Feb 4, 2022
sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this issue Feb 4, 2022
timovv added a commit that referenced this issue Feb 11, 2022
### Packages impacted by this PR

- `@azure/container-registry`

### Issues associated with this PR

- #19859

### Describe the problem that is addressed by this PR

Migrates ACR tests to the new recorder.
timovv added a commit that referenced this issue Feb 19, 2022
### Packages impacted by this PR

- `@azure/ai-text-analytics`

### Issues associated with this PR

- #19859

### Describe the problem that is addressed by this PR

Migrates Text Analytics to new recorder.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants