[Communication Chat] Migrate communication-chat tests to the new recorder #20278
Conversation
|
/azp run js - communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HarshaNalluru
requested review from
benbp and
praveenkuttappan
as code owners
|
/azp run js - communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| recorder = await createRecorder(this.currentTest); | ||
| if (!communicationUserToken) { | ||
| communicationUserToken = await createTestUser(recorder); | ||
| await recorder.setMatcher("HeaderlessMatcher"); |
There was a problem hiding this comment.
[Just FYI]
Headerless matcher matches the requests in playback without matching the headers in the recording.
Beyond the default skipped headers(to match), there was a new header specific to the communication service I believe, that was being dynamic. Hence using the headerless matcher.
There is going to be a custom-matcher soon from the test-proxy tool and the recorder, which will allow specifying the headers to be ignored while matching. Until then(even forever tbh), the Headerless matcher should be good and should do the job.
There was a problem hiding this comment.
Thanks for the explanation! Yes, our services return a dynamic ms-cv correlation vector.
.../recordings/browsers/chatclient_chat_operations/recording_successfully_creates_a_thread.json
Show resolved
Hide resolved
| recorder = await createRecorder(this.currentTest); | ||
| if (!communicationUserToken) { | ||
| communicationUserToken = await createTestUser(recorder); | ||
| await recorder.setMatcher("HeaderlessMatcher"); |
There was a problem hiding this comment.
Thanks for the explanation! Yes, our services return a dynamic ms-cv correlation vector.
| actualConnString: env["COMMUNICATION_LIVETEST_DYNAMIC_CONNECTION_STRING"] || undefined, | ||
| }, | ||
| ], | ||
| bodyKeySanitizers: [{ jsonPath: "$.accessToken.token", value: fakeToken }], |
There was a problem hiding this comment.
Seems like this didn't catch it.
There was a problem hiding this comment.
No, that's the fakeToken which also looks like a real token. 🥲
sdk/communication/communication-chat/test/public/utils/recordedClient.ts
Show resolved
Hide resolved
|
/azp run js - aggregate-reports |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
As the title says, this PR migrates the Communication chat tests to the new recorder.
Follows the migration guide at https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/MIGRATION.md
Note
The new recorder requires test-proxy to be run before running the tests.
For this, "docker" needs to be installed in your environment as suggested at https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/MIGRATION.md#prerequisites.
Part of #19859