Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Confidential Ledger tests to new recorder #20495

Closed
joheredi opened this issue Feb 22, 2022 · 0 comments · Fixed by #26305
Closed

Migrate Confidential Ledger tests to new recorder #20495

joheredi opened this issue Feb 22, 2022 · 0 comments · Fixed by #26305

Comments

@joheredi
Copy link
Member

See migration guide:https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/MIGRATION.md

@joheredi joheredi added this to the Backlog milestone Feb 22, 2022
xirzec added a commit that referenced this issue Jun 23, 2023
… externalize recordings (#26305)

### Packages impacted by this PR

`@azure-rest/confidential-ledger`
`@azure-tools/test-recorder`

### Issues associated with this PR

Fixes #20495

### Describe the problem that is addressed by this PR

Migrate to the latest test recorder in order to use the test proxy and
externalize recordings. I also had to regenerate the RLC in order to fix
an issue with `isUnexpected` not working properly for the user endpoint.

Getting the test resources to deploy correctly also took some doing
since it uses the `oid` and not the normal client id of the test app.

The tests themselves were a bit busted in places; I shored them up as
best I could given the odd behavior of the service.

Lastly, the test recorder didn't have support for any custom transport
options, so I had to add one in order to pass the `TLSValidationCert` in
order for it to work properly with confidential ledger.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@xirzec xirzec removed this from the Backlog milestone Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants